You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2016/08/02 22:50:30 UTC
Outstanding issues for 0.7 release
Hi,
There's a couple of licensing/policy issues outstanding AFAIK [1][2][3], also Im not sure if the issues with FlatUI [3] or encode/decode UTF8 [4] have been resolved or the possible GPL/MPL licensing issue [6]
Is there anything else I’ve missed?
Thanks,
Justin
1.https://lists.apache.org/thread.html/1a004703685e485171be7d0c52284f17308ea84b112b25de1299ca25@%3Cdev.flex.apache.org%3E
2.https://lists.apache.org/thread.html/d136caad460a14426ac8edad4cab2a17b66fdaa17a6652615b575d50@1462088622@%3Cdev.flex.apache.org%3E
3. https://lists.apache.org/thread.html/b903356e6441eb07d4884661f32c08646d45ef21c1196b44866d2240@1458953301@%3Cdev.flex.apache.org%3E
4. https://lists.apache.org/thread.html/867a1564c185b702f63219015954b77e95be1032e452c9d6fd77dc2e@%3Cdev.flex.apache.org%3E
5. https://lists.apache.org/thread.html/d5c13e79b2025808c67092c0d21e87509f2df5ef314d1d7111717ca8@%3Cdev.flex.apache.org%3E
6. https://lists.apache.org/thread.html/3da44249b845348f68148c523c67eeeb12d9e79d514678f033fbd24c@%3Cdev.flex.apache.org%3E
Re: Outstanding issues for 0.7 release
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I did not end up using that code. I used code from the Closure library which is Apache 2 licensed.
Which we were already using right. If so nothing more would need to be added to LICENSE or NOTICE (as it’s already there) so that’s one off the list.
Thanks,
Justin
Re: Outstanding issues for 0.7 release
Posted by Harbs <ha...@gmail.com>.
I did not end up using that code. I used code from the Closure library which is Apache 2 licensed.
On Aug 3, 2016, at 1:50 AM, Justin Mclean <ju...@classsoftware.com> wrote:
> or encode/decode UTF8
Re: Outstanding issues for 0.7 release
Posted by Alex Harui <ah...@adobe.com>.
Uber question: are we voting on the packages generated by the Ant script,
or did Chris finish the packaging via Maven? My answers below are about
the Ant script.
On 8/12/16, 12:19 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> 1) Is there CreateJS-licensed source in the source package?
>
>EaselJS and TweenJS are part of the CreateJS project so that’s probably a
>yes. Either way there's no harm in mentioning it.
I don't know what files you are referring to. I honestly don't think
there is EaselJS or TweenJS sources in the source package, just the patch
files which I believe are ASF-owned.
>
>> 3) License for svg.js. This file comes from
>> https://code.google.com/archive/p/closureidl/ where it says it is BSD 3
>> clause, but doesn't give us anything to copy or point
>
>If you download one of the zip files here [1] you’ll see it contains a
>LICENSE file with the license/copyright information.
I assume you agree it is BSD? It is now mentioned in LICENSE so I think
we are all set. If you or someone wants to upgrade the builds to download
that file that's fine with me although I'd rather not change what we
download right now.
-Alex
Re: Outstanding issues for 0.7 release
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I’m rewriting the functions in Matrix (and removing Vector3D as we’re not actually using it).
If the original is GPL licensed then this may not be enough [1][2][3][4]
Justin
1. https://s.apache.org/rewriting-code
2. http://programmers.stackexchange.com/questions/81705/rewriting-gpl-code-to-change-license
3. http://stackoverflow.com/questions/6326994/can-i-rewrite-a-piece-of-gpl-code-in-another-language-and-release-it-under-bsd
4. http://programmers.stackexchange.com/questions/86754/is-it-possible-to-rewrite-every-line-of-an-open-source-project-in-a-slightly-dif
Re: Outstanding issues for 0.7 release
Posted by Alex Harui <ah...@adobe.com>.
I was able to build without turning off RAT. Last night I think I fixed
the last issue in the RAT scan on the source package. You can't run RAT
on the repo yet.
-Alex
On 8/15/16, 10:28 AM, "piotrz" <pi...@gmail.com> wrote:
>I've also build with skipped RAT falcon and flexjs using maven without the
>problem.
>
>
>
>-----
>Apache Flex PMC
>piotrzarzycki21@gmail.com
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Just-got-my-first-Fle
>xJS-talk-accepted-tp54302p54502.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: Outstanding issues for 0.7 release
Posted by piotrz <pi...@gmail.com>.
I've also build with skipped RAT falcon and flexjs using maven without the
problem.
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Just-got-my-first-FlexJS-talk-accepted-tp54302p54502.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: Outstanding issues for 0.7 release
Posted by Alex Harui <ah...@adobe.com>.
OK, Does anybody else have any issues? I've unpacked the Ant-generated
packages for flex-falcon and flex-asjs and run Maven and the maven build
completes successfully on my Mac.
If no other issues, we could start a vote mid-week.
-Alex
On 8/14/16, 12:41 PM, "Harbs" <ha...@gmail.com> wrote:
>Thanks for the links.
>
>Openfl had the simplest implementation. There’s only so many ways you can
>write the solution to the same math problem… ;-)
>
>For the most part, I used the logic in that code, but I did not use it
>exactly.
>
>I just committed my changes. I improved the Matrix class to make the
>methods chain-able as well.
>
>We should be clear on this now.
>
>Thanks,
>Harbs
>
>On Aug 13, 2016, at 1:02 AM, Justin Mclean <ju...@classsoftware.com>
>wrote:
>
>> Hi,
>>
>>> I’m rewriting the functions in Matrix (and removing Vector3D as we’re
>>>not actually using it).
>>
>> Why rewrite when you could just use an Apache license compatible
>>version? i.e. from a recent version of Shumway (rather than the older
>>GPL/MPL version). [1] It's currently TypeScript but would be easy to
>>convert. Alternatively if you look in the history you should be able to
>>find where they changed from ActionScript to TypeScript but just check
>>the license is OK.
>>
>> Or perhaps the MIT licensed openfl [2] or Apache licensed Jangaroo libs
>>[3]. Jangaroo even has a pom file so there would be no need to bundle it
>>if you wanted to go down that path.
>>
>> There quite a few other implementations out there as well, just as long
>>as we know where it come from all is good.
>>
>> Thanks,
>> Justin
>>
>> 1.
>>https://github.com/mozilla/shumway/blob/master/src/flash/geom/Matrix.ts
>> 2. https://github.com/openfl/openfl/blob/develop/openfl/geom/Matrix.hx
>> 3.
>>https://github.com/CoreMedia/jangaroo-libs/blob/master/jooflash/src/main/
>>joo/flash/geom/Matrix.as
>
Re: Outstanding issues for 0.7 release
Posted by Harbs <ha...@gmail.com>.
Thanks for the links.
Openfl had the simplest implementation. There’s only so many ways you can write the solution to the same math problem… ;-)
For the most part, I used the logic in that code, but I did not use it exactly.
I just committed my changes. I improved the Matrix class to make the methods chain-able as well.
We should be clear on this now.
Thanks,
Harbs
On Aug 13, 2016, at 1:02 AM, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
>> I’m rewriting the functions in Matrix (and removing Vector3D as we’re not actually using it).
>
> Why rewrite when you could just use an Apache license compatible version? i.e. from a recent version of Shumway (rather than the older GPL/MPL version). [1] It's currently TypeScript but would be easy to convert. Alternatively if you look in the history you should be able to find where they changed from ActionScript to TypeScript but just check the license is OK.
>
> Or perhaps the MIT licensed openfl [2] or Apache licensed Jangaroo libs [3]. Jangaroo even has a pom file so there would be no need to bundle it if you wanted to go down that path.
>
> There quite a few other implementations out there as well, just as long as we know where it come from all is good.
>
> Thanks,
> Justin
>
> 1. https://github.com/mozilla/shumway/blob/master/src/flash/geom/Matrix.ts
> 2. https://github.com/openfl/openfl/blob/develop/openfl/geom/Matrix.hx
> 3. https://github.com/CoreMedia/jangaroo-libs/blob/master/jooflash/src/main/joo/flash/geom/Matrix.as
Re: Outstanding issues for 0.7 release
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I’m rewriting the functions in Matrix (and removing Vector3D as we’re not actually using it).
Why rewrite when you could just use an Apache license compatible version? i.e. from a recent version of Shumway (rather than the older GPL/MPL version). [1] It's currently TypeScript but would be easy to convert. Alternatively if you look in the history you should be able to find where they changed from ActionScript to TypeScript but just check the license is OK.
Or perhaps the MIT licensed openfl [2] or Apache licensed Jangaroo libs [3]. Jangaroo even has a pom file so there would be no need to bundle it if you wanted to go down that path.
There quite a few other implementations out there as well, just as long as we know where it come from all is good.
Thanks,
Justin
1. https://github.com/mozilla/shumway/blob/master/src/flash/geom/Matrix.ts
2. https://github.com/openfl/openfl/blob/develop/openfl/geom/Matrix.hx
3. https://github.com/CoreMedia/jangaroo-libs/blob/master/jooflash/src/main/joo/flash/geom/Matrix.as
Re: Outstanding issues for 0.7 release
Posted by Harbs <ha...@gmail.com>.
I’m rewriting the functions in Matrix (and removing Vector3D as we’re not actually using it).
I should be able to commit my changes on Monday.
On Aug 12, 2016, at 10:19 AM, Justin Mclean <ju...@classsoftware.com> wrote:
>> 8) Matrix.as and Vector3D.as
Re: Outstanding issues for 0.7 release
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> 1) Is there CreateJS-licensed source in the source package?
EaselJS and TweenJS are part of the CreateJS project so that’s probably a yes. Either way there's no harm in mentioning it.
> 3) License for svg.js. This file comes from
> https://code.google.com/archive/p/closureidl/ where it says it is BSD 3
> clause, but doesn't give us anything to copy or point
If you download one of the zip files here [1] you’ll see it contains a LICENSE file with the license/copyright information.
> 8) Matrix.as and Vector3D.as: I wrote to Lizhi for more information.
> However, specific to these two classes, do we have evidence that there are
> lines of code in these two files that have a copyright owner other than
> Liz?
Yes IMO there are blocks of code that look like they may of been copied from Shumway or perhaps elsewhere. There's no issue here if it was copied as long where it was copied from has an Apache compatible license.
The code is a little odd stylistically. For instance the use of brackets in this line in Matrix.as
result_b = result_b + (this.a * m.b + this.b * m.d);
Doing a google search for this shows the same code (and the rest of the function) from a decompiled version of the Flash Player. Now again I don’t know that is the original source of the code in Matrix.as, and it may not be the case. Would Adobe allowed us to use decompiled code from the Flash Player and claim it’s Apache licensed?
If you look at Vector.as it has some code commented out that starts with "if(watson(3109405))”. Why would that be there if it was a recent implementation from scratch based on the API? Again ether may be a reason for it’s existence but currently we don’t know.
BTW it looks like Lizhi's code is MIT licensed [2] not Apache. Should it have Apache headers on it in the repo? No issue either way just asking.
> Especially if, as I understand it, that APIs are not copyrightable?
We’re talking implementation not API.
Thanks,
Justin
1. https://code.google.com/archive/p/closureidl/downloads
2. https://github.com/matrix3d/spriteflexjs/blob/master/LICENSE
Re: Outstanding issues for 0.7 release
Posted by Alex Harui <ah...@adobe.com>.
I've made some updates to the falconjx release packages. A reminder: only
the flex-asjs and falconjx packages are up for release. The falcon-only
packages are not.
Culling and consolidating from the links, I think the list of issues is:
1) Is there CreateJS-licensed source in the source package? I think the
answer is no, but you did not mention what files you found. There are
patches in the source package. Patches are, AIUI, modifications and thus
the modifications are under ALv2. The patch files now contain the ASF
header and a note that they are generated from Ant script.
2) Old copyrights (2001-2005) and non-standard headers in some of the
source files. I found some old copyrights in compiler-build-tools/*.java
and compiler/src/test/java/utils/FlashplayerSecurityHandler.java. I
replaced the headers per Chris's reply.
3) License for svg.js. This file comes from
https://code.google.com/archive/p/closureidl/ where it says it is BSD 3
clause, but doesn't give us anything to copy or point to so I just added
to LICENSE that it is BSD without a copy or pointer
4) Copyright year for FDB properties files. These have been fixed.
5) License for Penner's easing equations. I copied the BSD license from
Penner's site into LICENSE.
6) Mention EaselJS and TweenJS in LICENSE. I added this to license and
copied the license into the binary packages.
7) Flat fonts are not distributed by Apache. The installer grabs them
from Flat and my personal build server after license acceptance.
8) Matrix.as and Vector3D.as: I wrote to Lizhi for more information.
However, specific to these two classes, do we have evidence that there are
lines of code in these two files that have a copyright owner other than
Lizhi? Especially if, as I understand it, that APIs are not
copyrightable? The shumway versions of these two files don't seem to have
any implementations.
On 8/2/16, 3:50 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>There's a couple of licensing/policy issues outstanding AFAIK [1][2][3],
>also Im not sure if the issues with FlatUI [3] or encode/decode UTF8 [4]
>have been resolved or the possible GPL/MPL licensing issue [6]
>
>Is there anything else I’ve missed?
>
>Thanks,
>Justin
>
>1.https://lists.apache.org/thread.html/1a004703685e485171be7d0c52284f17308
>ea84b112b25de1299ca25@%3Cdev.flex.apache.org%3E
>2.https://lists.apache.org/thread.html/d136caad460a14426ac8edad4cab2a17b66
>fdaa17a6652615b575d50@1462088622@%3Cdev.flex.apache.org%3E
>3.
>https://lists.apache.org/thread.html/b903356e6441eb07d4884661f32c08646d45e
>f21c1196b44866d2240@1458953301@%3Cdev.flex.apache.org%3E
>4.
>https://lists.apache.org/thread.html/867a1564c185b702f63219015954b77e95be1
>032e452c9d6fd77dc2e@%3Cdev.flex.apache.org%3E
>5.
>https://lists.apache.org/thread.html/d5c13e79b2025808c67092c0d21e87509f2df
>5ef314d1d7111717ca8@%3Cdev.flex.apache.org%3E
>6.
>https://lists.apache.org/thread.html/3da44249b845348f68148c523c67eeeb12d9e
>79d514678f033fbd24c@%3Cdev.flex.apache.org%3E
Re: Outstanding issues for 0.7 release
Posted by Alex Harui <ah...@adobe.com>.
On 8/2/16, 4:37 PM, "omuppi1@gmail.com on behalf of OmPrakash Muppirala"
<omuppi1@gmail.com on behalf of bigosmallm@gmail.com> wrote:
>What is a good location for testing out the 0.7 binary? I want to test
>out
>the npm installer.
Nightly build?
http://apacheflexbuild.cloudapp.net:8080/job/flex-falcon/lastSuccessfulBuil
d/artifact/
http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/lastSuccessfulBuild/
artifact/
-Alex
Re: Outstanding issues for 0.7 release
Posted by OmPrakash Muppirala <bi...@gmail.com>.
What is a good location for testing out the 0.7 binary? I want to test out
the npm installer.
Thanks,
Om
On Tue, Aug 2, 2016 at 3:50 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> There's a couple of licensing/policy issues outstanding AFAIK [1][2][3],
> also Im not sure if the issues with FlatUI [3] or encode/decode UTF8 [4]
> have been resolved or the possible GPL/MPL licensing issue [6]
>
> Is there anything else I’ve missed?
>
> Thanks,
> Justin
>
> 1.
> https://lists.apache.org/thread.html/1a004703685e485171be7d0c52284f17308ea84b112b25de1299ca25@%3Cdev.flex.apache.org%3E
> 2.
> https://lists.apache.org/thread.html/d136caad460a14426ac8edad4cab2a17b66fdaa17a6652615b575d50@1462088622@%3Cdev.flex.apache.org%3E
> 3.
> https://lists.apache.org/thread.html/b903356e6441eb07d4884661f32c08646d45ef21c1196b44866d2240@1458953301@%3Cdev.flex.apache.org%3E
> 4.
> https://lists.apache.org/thread.html/867a1564c185b702f63219015954b77e95be1032e452c9d6fd77dc2e@%3Cdev.flex.apache.org%3E
> 5.
> https://lists.apache.org/thread.html/d5c13e79b2025808c67092c0d21e87509f2df5ef314d1d7111717ca8@%3Cdev.flex.apache.org%3E
> 6.
> https://lists.apache.org/thread.html/3da44249b845348f68148c523c67eeeb12d9e79d514678f033fbd24c@%3Cdev.flex.apache.org%3E