[GitHub] [arrow] kou commented on a change in pull request #11375: ARROW-14236: [C++] add GCS testbench for testing

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #11375:
URL: https://github.com/apache/arrow/pull/11375#discussion_r725747648



##########
File path: ci/docker/debian-10-cpp.dockerfile
##########
@@ -65,15 +65,18 @@ RUN apt-get update -y -q && \
         ninja-build \
         pkg-config \
         protobuf-compiler \
+        python3-pip \
         rapidjson-dev \
         tzdata \
         zlib1g-dev && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/*
 
 COPY ci/scripts/install_minio.sh \
+     ci/scripts/install_gcs_testbench.sh \
      /arrow/ci/scripts/
 RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
+RUN /arrow/ci/scripts/install_gcs_testbench.sh default

Review comment:
       Not unifying `COPY` is a bit better because we can omit installing minio when `install_gcs_testbench.sh` is only changed:
   
   ```suggestion
   COPY ci/scripts/install_minio.sh \
        /arrow/ci/scripts/
   RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
   COPY ci/scripts/install_gcs_testbench.sh \
        /arrow/ci/scripts
   RUN /arrow/ci/scripts/install_gcs_testbench.sh default
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org