[GitHub] [cordova-docs] NiklasMerz commented on a change in pull request #1063: Team page

[GitBox <gi...@apache.org>]

NiklasMerz commented on a change in pull request #1063:
URL: https://github.com/apache/cordova-docs/pull/1063#discussion_r507194573



##########
File path: www/contribute/team.html
##########
@@ -0,0 +1,38 @@
+---
+layout: team
+title: Team
+---
+
+<div class="row">
+    <div class="col-sm-12 text-center">
+        <h1>Team</h1>
+        <p>These are some of people behind Apache Cordova</p>
+    </div>
+</div>
+
+{% for member in site.members %}
+<div class="row">
+    <div class="col-sm-8 col-xs-8">
+        <span>
+            <h2>{{ member.name }}</h2>
+            <p>{{ member.subtitle }}</p>
+        </span>
+    </div>
+</div>
+<div class="row">
+    <div class="col-sm-8">
+        <p>
+            {{ member.content }}
+        </p>
+    </div>
+    <div class="col-sm-3 col-sm-offset-1">
+        <img src="{{ member.imageurl }}"><img>
+        {% if member.twitter %}
+            <a href="{{ member.twitter }}">Twitter</a>

Review comment:
       To be hones I don't want to figure out how to include another icon set just for this. I also thought doing this dynamically for include like 3 custom links with their own labels. If that's a good idea we can do that maybe later?
   
   I don't like working on this because the built is just painfully slow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org