You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by babokim <gi...@git.apache.org> on 2014/07/14 09:30:04 UTC
[GitHub] tajo pull request: TAJO-20: INSERT INTO ... SELECT
GitHub user babokim opened a pull request:
https://github.com/apache/tajo/pull/72
TAJO-20: INSERT INTO ... SELECT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/babokim/tajo TAJO-20
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 859811075866addc65a46e368701f0f59e71bf74
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date: 2014-06-04T09:22:07Z
TAJO-20: INSERT INTO ... SELECT
commit fd9397c6879603974f8e5dbe253161d14fa644aa
Author: 김형준 <ba...@babokim-mbp.server.gruter.com>
Date: 2014-07-14T05:45:46Z
TAJO-20: INSERT INTO ... SELECT
commit 5ac57239f7dc75924a10be676edf1ec938beba47
Author: 김형준 <ba...@babokim-mbp.server.gruter.com>
Date: 2014-07-14T07:28:03Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-20
Conflicts:
tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-20: INSERT INTO ... SELECT
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/72#discussion_r14921641
--- Diff: tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java ---
@@ -279,6 +280,131 @@ public final void testColumnPartitionedTableByThreeColumns() throws Exception {
}
@Test
+ public final void to() throws Exception {
--- End diff --
You intended 'testInsertIntoColumnPartitionedTableByThreeColumns' because 'testInsertIntoColumnPartitionedTableByThreeColumns' is included in unit test code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-20: INSERT INTO ... SELECT
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-20: INSERT INTO ... SELECT
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/72#issuecomment-49004222
+1
In overall, the patch looks nice to me, and it includes nice unit tests. I also verified 'mvn clean install'.
Before commiting it, I'll do as follows:
* add more comments to new implemented methods
* rename the unit test method that I pointed out
* removed unused static variable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-20: INSERT INTO ... SELECT
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/72#discussion_r14919779
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java ---
@@ -43,6 +51,17 @@
protected final int [] keyIds;
protected final String [] keyNames;
+ static final ThreadLocal<NumberFormat> OUTPUT_FILE_FORMAT_SEQ =
--- End diff --
It seems to be not used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-20: INSERT INTO ... SELECT
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/72#discussion_r14919794
--- Diff: tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java ---
@@ -378,20 +378,7 @@ private void initStagingDir() throws IOException {
// Create a subdirectories
LOG.info("The staging dir '" + stagingDir + "' is created.");
-
queryContext.setStagingDir(stagingDir);
-
- /////////////////////////////////////////////////
- // Check and Create Output Directory If Necessary
- /////////////////////////////////////////////////
- if (queryContext.hasOutputPath()) {
- outputDir = queryContext.getOutputPath();
--- End diff --
after this removal, outputDir is not used anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---