You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/02/27 13:41:51 UTC

[GitHub] zhongjiajie commented on a change in pull request #4699: [AIRFLOW-3881] Correct to_csv row number

zhongjiajie commented on a change in pull request #4699: [AIRFLOW-3881] Correct to_csv row number
URL: https://github.com/apache/airflow/pull/4699#discussion_r260752529
 
 

 ##########
 File path: tests/hooks/test_hive_hook.py
 ##########
 @@ -451,7 +452,23 @@ def test_get_results_data(self):
         results = hook.get_results(query, schema=self.database)
         self.assertListEqual(results['data'], [(1, 1), (2, 2)])
 
-    def test_to_csv(self):
+    @unittest.skipIf(NOT_ASSERTLOGS_VERSION < 3.4, 'assertLogs not support before python 3.4')
 
 Review comment:
   @Fokko But our CI test will run in python 2.7. If we remove, `test_to_csv` will only test python >= 3.4 and don't cover python < 3.4

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services