[jira] [Commented] (ARROW-886) VariableLengthVectors don't reAlloc offsets

["Steven Phillips (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043775#comment-16043775 ] 

Steven Phillips commented on ARROW-886:
---------------------------------------

I'm just now noticing this, but this change (along with ARROW-815) actually breaks the way that reAlloc was designed to work. It was originally meant to be an internal method, which was used by the various setSafe() methods. The idea was that a user of the ValueVector could call setSafe() instead of set(), and this would automatically and transparently handle the expansion of the underlying buffer in the event that we reached the end of the currently allocated buffer.

For variable length vectors, the re-allocation of the data buffer should be completely independent of the re-allocation of the offset vector's buffer. But this change causes reAlloc() to be called on the offset vector anytime reAlloc() is called on the parent vector.

> VariableLengthVectors don't reAlloc offsets
> -------------------------------------------
>
>                 Key: ARROW-886
>                 URL: https://issues.apache.org/jira/browse/ARROW-886
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java - Vectors
>    Affects Versions: 0.3.0
>            Reporter: Emilio Lahr-Vivaz
>            Assignee: Emilio Lahr-Vivaz
>             Fix For: 0.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)