You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/07 17:15:43 UTC
[GitHub] [incubator-superset] riahk opened a new pull request #11189: Moriah/css templates list
riahk opened a new pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189
### SUMMARY
- [x] Updated routing to setup CSS Templates React view
- [x] Accessible with feature flags `ENABLE_REACT_CRUD_VIEWS` and `SIP_34_CSS_TEMPLATES_UI`
- [x] Add `CssTemplatesList`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1142" alt="Screen Shot 2020-10-07 at 10 13 17 AM" src="https://user-images.githubusercontent.com/8216382/95364515-c5f87880-0885-11eb-8039-31806559b0c2.png">
### TEST PLAN
- [x] Add spec file
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a10e86ab318786fd43833d401e374b5a75ae838e?el=desc) will **decrease** coverage by `5.27%`.
> The diff coverage is `72.72%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.61% 60.34% -5.28%
==========================================
Files 828 392 -436
Lines 39148 24566 -14582
Branches 3589 0 -3589
==========================================
- Hits 25687 14824 -10863
+ Misses 13350 9742 -3608
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.34% <72.72%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.67%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
| [...rset/superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb250cm9sVXRpbHMuanM=) | | |
| ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [a10e86a...420251d](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.31%`.
> The diff coverage is `89.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.43% 61.11% -4.32%
==========================================
Files 829 830 +1
Lines 39200 39246 +46
Branches 3693 3700 +7
==========================================
- Hits 25649 23987 -1662
- Misses 13444 15077 +1633
- Partials 107 182 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.41% <94.73%> (+0.08%)` | :arrow_up: |
| #python | `60.34% <72.72%> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-31.43%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `97.29% <97.29%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [9785667...1085dcb](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a10e86ab318786fd43833d401e374b5a75ae838e?el=desc) will **decrease** coverage by `4.19%`.
> The diff coverage is `72.72%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.61% 61.41% -4.20%
==========================================
Files 828 829 +1
Lines 39148 39194 +46
Branches 3589 3596 +7
==========================================
- Hits 25687 24072 -1615
- Misses 13350 14941 +1591
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.38% <ø> (+0.08%)` | :arrow_up: |
| #python | `60.84% <72.72%> (-0.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [a10e86a...420251d](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a10e86ab318786fd43833d401e374b5a75ae838e?el=desc) will **decrease** coverage by `5.30%`.
> The diff coverage is `72.72%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.61% 60.30% -5.31%
==========================================
Files 828 392 -436
Lines 39148 24555 -14593
Branches 3589 0 -3589
==========================================
- Hits 25687 14808 -10879
+ Misses 13350 9747 -3603
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.30% <72.72%> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.67%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.55% <0.00%> (-0.29%)` | :arrow_down: |
| ... and [441 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [a10e86a...420251d](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `89.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 61.69% 61.34% -0.36%
==========================================
Files 828 830 +2
Lines 39116 39246 +130
Branches 3688 3700 +12
==========================================
- Hits 24134 24076 -58
- Misses 14801 14988 +187
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.41% <94.73%> (+0.11%)` | :arrow_up: |
| #python | `60.70% <72.72%> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `97.29% <97.29%> (ø)` | |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `22.00% <0.00%> (-78.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.17% <0.00%> (-3.20%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [13963ac...2debb94](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `89.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 61.69% 61.54% -0.16%
==========================================
Files 828 830 +2
Lines 39116 39246 +130
Branches 3688 3700 +12
==========================================
+ Hits 24134 24154 +20
- Misses 14801 14910 +109
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.41% <94.73%> (+0.11%)` | :arrow_up: |
| #python | `61.02% <72.72%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `97.29% <97.29%> (ø)` | |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `22.00% <0.00%> (-78.00%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `95.00% <0.00%> (-2.50%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `27.77% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <0.00%> (-1.54%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `86.66% <0.00%> (-0.84%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `76.11% <0.00%> (-0.40%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.57% <0.00%> (-0.29%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [13963ac...2debb94](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `0.70%`.
> The diff coverage is `89.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 61.69% 60.99% -0.71%
==========================================
Files 828 830 +2
Lines 39116 39246 +130
Branches 3688 3700 +12
==========================================
- Hits 24134 23938 -196
- Misses 14801 15126 +325
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.41% <94.73%> (+0.11%)` | :arrow_up: |
| #python | `60.14% <72.72%> (-1.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `97.29% <97.29%> (ø)` | |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `22.00% <0.00%> (-78.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-7.78%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [13963ac...2debb94](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `4.15%`.
> The diff coverage is `89.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.43% 61.27% -4.16%
==========================================
Files 829 830 +1
Lines 39200 39246 +46
Branches 3693 3700 +7
==========================================
- Hits 25649 24049 -1600
- Misses 13444 15015 +1571
- Partials 107 182 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.41% <94.73%> (+0.08%)` | :arrow_up: |
| #python | `60.59% <72.72%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-31.43%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `97.29% <97.29%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [169 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [9785667...1085dcb](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `5.13%`.
> The diff coverage is `72.72%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.43% 60.29% -5.14%
==========================================
Files 829 392 -437
Lines 39200 24580 -14620
Branches 3693 0 -3693
==========================================
- Hits 25649 14820 -10829
+ Misses 13444 9760 -3684
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.29% <72.72%> (-0.32%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-1.39%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.56% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.01% <0.00%> (-0.25%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | | |
| ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [9785667...1085dcb](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `89.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 61.69% 61.52% -0.17%
==========================================
Files 828 830 +2
Lines 39116 39246 +130
Branches 3688 3700 +12
==========================================
+ Hits 24134 24148 +14
- Misses 14801 14916 +115
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.41% <94.73%> (+0.11%)` | :arrow_up: |
| #python | `61.00% <72.72%> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `97.29% <97.29%> (ø)` | |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `22.00% <0.00%> (-78.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `95.00% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `27.77% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.67% <0.00%> (-1.54%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [13963ac...2debb94](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#discussion_r502048698
##########
File path: superset-frontend/src/views/CRUD/csstemplates/CssTemplatesList.tsx
##########
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { useMemo } from 'react';
+import { t } from '@superset-ui/core';
+import moment from 'moment';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { IconName } from 'src/components/Icon';
+import ActionsBar, { ActionProps } from 'src/components/ListView/ActionsBar';
+// import ListView, { Filters } from 'src/components/ListView';
Review comment:
nit: commented out code
##########
File path: superset-frontend/spec/javascripts/views/CRUD/csstemplates/CssTemplatesList_spec.jsx
##########
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import thunk from 'redux-thunk';
+import configureStore from 'redux-mock-store';
+import fetchMock from 'fetch-mock';
+import { styledMount as mount } from 'spec/helpers/theming';
+
+import CssTemplatesList from 'src/views/CRUD/csstemplates/CssTemplatesList';
+import SubMenu from 'src/components/Menu/SubMenu';
+import ListView from 'src/components/ListView';
+// import Filters from 'src/components/ListView/Filters';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+// import { act } from 'react-dom/test-utils';
+
+// store needed for withToasts(DatabaseList)
Review comment:
nit: incorrect comment
##########
File path: superset-frontend/spec/javascripts/views/CRUD/csstemplates/CssTemplatesList_spec.jsx
##########
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import thunk from 'redux-thunk';
+import configureStore from 'redux-mock-store';
+import fetchMock from 'fetch-mock';
+import { styledMount as mount } from 'spec/helpers/theming';
+
+import CssTemplatesList from 'src/views/CRUD/csstemplates/CssTemplatesList';
+import SubMenu from 'src/components/Menu/SubMenu';
+import ListView from 'src/components/ListView';
+// import Filters from 'src/components/ListView/Filters';
Review comment:
nit: commented out code
##########
File path: superset-frontend/src/views/CRUD/csstemplates/CssTemplatesList.tsx
##########
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { useMemo } from 'react';
+import { t } from '@superset-ui/core';
+import moment from 'moment';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { IconName } from 'src/components/Icon';
+import ActionsBar, { ActionProps } from 'src/components/ListView/ActionsBar';
+// import ListView, { Filters } from 'src/components/ListView';
+import ListView from 'src/components/ListView';
+
+const PAGE_SIZE = 25;
+
+interface CssTemplatesListProps {
+ addDangerToast: (msg: string) => void;
+ addSuccessToast: (msg: string) => void;
+}
+
+type TemplateObject = {
+ id?: number;
+ changed_on_delta_humanized: string;
+ created_on: string;
+ created_by: {
+ id: number;
+ first_name: string;
+ last_name: string;
+ };
+ css: string;
+ template_name: string;
+};
+
+function CssTemplatesList({
+ addDangerToast,
+ addSuccessToast,
+}: CssTemplatesListProps) {
+ const {
+ state: {
+ loading,
+ resourceCount: templatesCount,
+ resourceCollection: templates,
+ },
+ hasPerm,
+ fetchData,
+ // refreshData,
+ } = useListViewResource<TemplateObject>(
+ 'css_template',
+ t('css templates'),
+ addDangerToast,
+ );
+
+ const canCreate = hasPerm('can_add');
+ const canEdit = hasPerm('can_edit');
+ const canDelete = hasPerm('can_delete');
+
+ const initialSort = [{ id: 'template_name', desc: true }];
+ const columns = useMemo(
+ () => [
+ {
+ accessor: 'template_name',
+ Header: t('Name'),
+ },
+ {
+ Cell: ({
+ row: {
+ original: { created_on: createdOn },
+ },
+ }: any) => {
+ const date = new Date(createdOn);
+ const utc = new Date(
+ Date.UTC(
+ date.getFullYear(),
+ date.getMonth(),
+ date.getDate(),
+ date.getHours(),
+ date.getMinutes(),
+ date.getSeconds(),
+ date.getMilliseconds(),
+ ),
+ );
+
+ return moment(utc).fromNow();
+ },
+ Header: t('Created On'),
+ accessor: 'created_on',
+ size: 'xl',
+ },
+ {
+ accessor: 'created_by',
+ disableSortBy: true,
+ Header: t('Created By'),
+ Cell: ({
+ row: {
+ original: { created_by: createdBy },
+ },
+ }: any) =>
+ createdBy ? `${createdBy.first_name} ${createdBy.last_name}` : '',
+ size: 'xl',
+ },
+ {
+ Cell: ({
+ row: {
+ original: { changed_on_delta_humanized: changedOn },
+ },
+ }: any) => changedOn,
+ Header: t('Last Modified'),
+ accessor: 'changed_on_delta_humanized',
+ size: 'xl',
+ },
+ {
+ Cell: ({ row: { original } }: any) => {
+ const handleEdit = () => {}; // handleDatabaseEdit(original);
+ const handleDelete = () => {}; // openDatabaseDeleteModal(original);
+
+ const actions = [
+ canEdit
+ ? {
+ label: 'edit-action',
+ tooltip: t('Edit template'),
+ placement: 'bottom',
+ icon: 'edit' as IconName,
+ onClick: handleEdit,
+ }
+ : null,
+ canDelete
+ ? {
+ label: 'delete-action',
+ tooltip: t('Delete template'),
+ placement: 'bottom',
+ icon: 'trash' as IconName,
+ onClick: handleDelete,
+ }
+ : null,
+ ].filter(item => !!item);
+
+ if (!canEdit && !canDelete) {
+ return null;
+ }
+
+ return <ActionsBar actions={actions as ActionProps[]} />;
+ },
+ Header: t('Actions'),
+ id: 'actions',
+ disableSortBy: true,
+ size: 'xl',
+ },
+ ],
+ [canDelete, canCreate],
+ );
+
+ return (
+ <>
+ <SubMenu name={t('CSS Templates')} />
+ <ListView<TemplateObject>
+ className="css-templates-list-view"
+ columns={columns}
+ count={templatesCount}
+ data={templates}
+ fetchData={fetchData}
+ // filters={filters}
Review comment:
nit: commented out code
##########
File path: superset-frontend/src/views/CRUD/csstemplates/CssTemplatesList.tsx
##########
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { useMemo } from 'react';
+import { t } from '@superset-ui/core';
+import moment from 'moment';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { IconName } from 'src/components/Icon';
+import ActionsBar, { ActionProps } from 'src/components/ListView/ActionsBar';
+// import ListView, { Filters } from 'src/components/ListView';
+import ListView from 'src/components/ListView';
+
+const PAGE_SIZE = 25;
+
+interface CssTemplatesListProps {
+ addDangerToast: (msg: string) => void;
+ addSuccessToast: (msg: string) => void;
+}
+
+type TemplateObject = {
+ id?: number;
+ changed_on_delta_humanized: string;
+ created_on: string;
+ created_by: {
+ id: number;
+ first_name: string;
+ last_name: string;
+ };
+ css: string;
+ template_name: string;
+};
+
+function CssTemplatesList({
+ addDangerToast,
+ addSuccessToast,
+}: CssTemplatesListProps) {
+ const {
+ state: {
+ loading,
+ resourceCount: templatesCount,
+ resourceCollection: templates,
+ },
+ hasPerm,
+ fetchData,
+ // refreshData,
+ } = useListViewResource<TemplateObject>(
+ 'css_template',
+ t('css templates'),
+ addDangerToast,
+ );
+
+ const canCreate = hasPerm('can_add');
+ const canEdit = hasPerm('can_edit');
+ const canDelete = hasPerm('can_delete');
+
+ const initialSort = [{ id: 'template_name', desc: true }];
+ const columns = useMemo(
+ () => [
+ {
+ accessor: 'template_name',
+ Header: t('Name'),
+ },
+ {
+ Cell: ({
+ row: {
+ original: { created_on: createdOn },
+ },
+ }: any) => {
+ const date = new Date(createdOn);
+ const utc = new Date(
+ Date.UTC(
+ date.getFullYear(),
+ date.getMonth(),
+ date.getDate(),
+ date.getHours(),
+ date.getMinutes(),
+ date.getSeconds(),
+ date.getMilliseconds(),
+ ),
+ );
+
+ return moment(utc).fromNow();
+ },
+ Header: t('Created On'),
+ accessor: 'created_on',
+ size: 'xl',
+ },
+ {
+ accessor: 'created_by',
+ disableSortBy: true,
+ Header: t('Created By'),
+ Cell: ({
+ row: {
+ original: { created_by: createdBy },
+ },
+ }: any) =>
+ createdBy ? `${createdBy.first_name} ${createdBy.last_name}` : '',
+ size: 'xl',
+ },
+ {
+ Cell: ({
+ row: {
+ original: { changed_on_delta_humanized: changedOn },
+ },
+ }: any) => changedOn,
+ Header: t('Last Modified'),
+ accessor: 'changed_on_delta_humanized',
+ size: 'xl',
+ },
+ {
+ Cell: ({ row: { original } }: any) => {
+ const handleEdit = () => {}; // handleDatabaseEdit(original);
+ const handleDelete = () => {}; // openDatabaseDeleteModal(original);
Review comment:
nit: incorrectly named and commented out code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a10e86ab318786fd43833d401e374b5a75ae838e?el=desc) will **decrease** coverage by `4.08%`.
> The diff coverage is `72.72%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.61% 61.53% -4.09%
==========================================
Files 828 829 +1
Lines 39148 39194 +46
Branches 3589 3596 +7
==========================================
- Hits 25687 24117 -1570
- Misses 13350 14896 +1546
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.38% <ø> (+0.08%)` | :arrow_up: |
| #python | `61.02% <72.72%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [168 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [a10e86a...420251d](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `89.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 61.69% 61.52% -0.18%
==========================================
Files 828 830 +2
Lines 39116 39246 +130
Branches 3688 3700 +12
==========================================
+ Hits 24134 24146 +12
- Misses 14801 14918 +117
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.41% <94.73%> (+0.11%)` | :arrow_up: |
| #python | `60.99% <72.72%> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `97.29% <97.29%> (ø)` | |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `22.00% <0.00%> (-78.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `95.00% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `27.77% <0.00%> (-1.64%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [13963ac...2debb94](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9785667a0dc970fd7b7033f172c2760ee0c22a6e?el=desc) will **decrease** coverage by `5.52%`.
> The diff coverage is `89.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.43% 59.90% -5.53%
==========================================
Files 829 1234 +405
Lines 39200 52636 +13436
Branches 3693 7135 +3442
==========================================
+ Hits 25649 31530 +5881
- Misses 13444 20740 +7296
- Partials 107 366 +259
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.87% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `62.41% <94.73%> (+0.08%)` | :arrow_up: |
| #python | `60.59% <72.72%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-31.43%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `97.29% <97.29%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [573 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [9785667...1085dcb](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#discussion_r502048698
##########
File path: superset-frontend/src/views/CRUD/csstemplates/CssTemplatesList.tsx
##########
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { useMemo } from 'react';
+import { t } from '@superset-ui/core';
+import moment from 'moment';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { IconName } from 'src/components/Icon';
+import ActionsBar, { ActionProps } from 'src/components/ListView/ActionsBar';
+// import ListView, { Filters } from 'src/components/ListView';
Review comment:
nit: commented out code
##########
File path: superset-frontend/spec/javascripts/views/CRUD/csstemplates/CssTemplatesList_spec.jsx
##########
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import thunk from 'redux-thunk';
+import configureStore from 'redux-mock-store';
+import fetchMock from 'fetch-mock';
+import { styledMount as mount } from 'spec/helpers/theming';
+
+import CssTemplatesList from 'src/views/CRUD/csstemplates/CssTemplatesList';
+import SubMenu from 'src/components/Menu/SubMenu';
+import ListView from 'src/components/ListView';
+// import Filters from 'src/components/ListView/Filters';
+import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
+// import { act } from 'react-dom/test-utils';
+
+// store needed for withToasts(DatabaseList)
Review comment:
nit: incorrect comment
##########
File path: superset-frontend/spec/javascripts/views/CRUD/csstemplates/CssTemplatesList_spec.jsx
##########
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import thunk from 'redux-thunk';
+import configureStore from 'redux-mock-store';
+import fetchMock from 'fetch-mock';
+import { styledMount as mount } from 'spec/helpers/theming';
+
+import CssTemplatesList from 'src/views/CRUD/csstemplates/CssTemplatesList';
+import SubMenu from 'src/components/Menu/SubMenu';
+import ListView from 'src/components/ListView';
+// import Filters from 'src/components/ListView/Filters';
Review comment:
nit: commented out code
##########
File path: superset-frontend/src/views/CRUD/csstemplates/CssTemplatesList.tsx
##########
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { useMemo } from 'react';
+import { t } from '@superset-ui/core';
+import moment from 'moment';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { IconName } from 'src/components/Icon';
+import ActionsBar, { ActionProps } from 'src/components/ListView/ActionsBar';
+// import ListView, { Filters } from 'src/components/ListView';
+import ListView from 'src/components/ListView';
+
+const PAGE_SIZE = 25;
+
+interface CssTemplatesListProps {
+ addDangerToast: (msg: string) => void;
+ addSuccessToast: (msg: string) => void;
+}
+
+type TemplateObject = {
+ id?: number;
+ changed_on_delta_humanized: string;
+ created_on: string;
+ created_by: {
+ id: number;
+ first_name: string;
+ last_name: string;
+ };
+ css: string;
+ template_name: string;
+};
+
+function CssTemplatesList({
+ addDangerToast,
+ addSuccessToast,
+}: CssTemplatesListProps) {
+ const {
+ state: {
+ loading,
+ resourceCount: templatesCount,
+ resourceCollection: templates,
+ },
+ hasPerm,
+ fetchData,
+ // refreshData,
+ } = useListViewResource<TemplateObject>(
+ 'css_template',
+ t('css templates'),
+ addDangerToast,
+ );
+
+ const canCreate = hasPerm('can_add');
+ const canEdit = hasPerm('can_edit');
+ const canDelete = hasPerm('can_delete');
+
+ const initialSort = [{ id: 'template_name', desc: true }];
+ const columns = useMemo(
+ () => [
+ {
+ accessor: 'template_name',
+ Header: t('Name'),
+ },
+ {
+ Cell: ({
+ row: {
+ original: { created_on: createdOn },
+ },
+ }: any) => {
+ const date = new Date(createdOn);
+ const utc = new Date(
+ Date.UTC(
+ date.getFullYear(),
+ date.getMonth(),
+ date.getDate(),
+ date.getHours(),
+ date.getMinutes(),
+ date.getSeconds(),
+ date.getMilliseconds(),
+ ),
+ );
+
+ return moment(utc).fromNow();
+ },
+ Header: t('Created On'),
+ accessor: 'created_on',
+ size: 'xl',
+ },
+ {
+ accessor: 'created_by',
+ disableSortBy: true,
+ Header: t('Created By'),
+ Cell: ({
+ row: {
+ original: { created_by: createdBy },
+ },
+ }: any) =>
+ createdBy ? `${createdBy.first_name} ${createdBy.last_name}` : '',
+ size: 'xl',
+ },
+ {
+ Cell: ({
+ row: {
+ original: { changed_on_delta_humanized: changedOn },
+ },
+ }: any) => changedOn,
+ Header: t('Last Modified'),
+ accessor: 'changed_on_delta_humanized',
+ size: 'xl',
+ },
+ {
+ Cell: ({ row: { original } }: any) => {
+ const handleEdit = () => {}; // handleDatabaseEdit(original);
+ const handleDelete = () => {}; // openDatabaseDeleteModal(original);
+
+ const actions = [
+ canEdit
+ ? {
+ label: 'edit-action',
+ tooltip: t('Edit template'),
+ placement: 'bottom',
+ icon: 'edit' as IconName,
+ onClick: handleEdit,
+ }
+ : null,
+ canDelete
+ ? {
+ label: 'delete-action',
+ tooltip: t('Delete template'),
+ placement: 'bottom',
+ icon: 'trash' as IconName,
+ onClick: handleDelete,
+ }
+ : null,
+ ].filter(item => !!item);
+
+ if (!canEdit && !canDelete) {
+ return null;
+ }
+
+ return <ActionsBar actions={actions as ActionProps[]} />;
+ },
+ Header: t('Actions'),
+ id: 'actions',
+ disableSortBy: true,
+ size: 'xl',
+ },
+ ],
+ [canDelete, canCreate],
+ );
+
+ return (
+ <>
+ <SubMenu name={t('CSS Templates')} />
+ <ListView<TemplateObject>
+ className="css-templates-list-view"
+ columns={columns}
+ count={templatesCount}
+ data={templates}
+ fetchData={fetchData}
+ // filters={filters}
Review comment:
nit: commented out code
##########
File path: superset-frontend/src/views/CRUD/csstemplates/CssTemplatesList.tsx
##########
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { useMemo } from 'react';
+import { t } from '@superset-ui/core';
+import moment from 'moment';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import SubMenu from 'src/components/Menu/SubMenu';
+import { IconName } from 'src/components/Icon';
+import ActionsBar, { ActionProps } from 'src/components/ListView/ActionsBar';
+// import ListView, { Filters } from 'src/components/ListView';
+import ListView from 'src/components/ListView';
+
+const PAGE_SIZE = 25;
+
+interface CssTemplatesListProps {
+ addDangerToast: (msg: string) => void;
+ addSuccessToast: (msg: string) => void;
+}
+
+type TemplateObject = {
+ id?: number;
+ changed_on_delta_humanized: string;
+ created_on: string;
+ created_by: {
+ id: number;
+ first_name: string;
+ last_name: string;
+ };
+ css: string;
+ template_name: string;
+};
+
+function CssTemplatesList({
+ addDangerToast,
+ addSuccessToast,
+}: CssTemplatesListProps) {
+ const {
+ state: {
+ loading,
+ resourceCount: templatesCount,
+ resourceCollection: templates,
+ },
+ hasPerm,
+ fetchData,
+ // refreshData,
+ } = useListViewResource<TemplateObject>(
+ 'css_template',
+ t('css templates'),
+ addDangerToast,
+ );
+
+ const canCreate = hasPerm('can_add');
+ const canEdit = hasPerm('can_edit');
+ const canDelete = hasPerm('can_delete');
+
+ const initialSort = [{ id: 'template_name', desc: true }];
+ const columns = useMemo(
+ () => [
+ {
+ accessor: 'template_name',
+ Header: t('Name'),
+ },
+ {
+ Cell: ({
+ row: {
+ original: { created_on: createdOn },
+ },
+ }: any) => {
+ const date = new Date(createdOn);
+ const utc = new Date(
+ Date.UTC(
+ date.getFullYear(),
+ date.getMonth(),
+ date.getDate(),
+ date.getHours(),
+ date.getMinutes(),
+ date.getSeconds(),
+ date.getMilliseconds(),
+ ),
+ );
+
+ return moment(utc).fromNow();
+ },
+ Header: t('Created On'),
+ accessor: 'created_on',
+ size: 'xl',
+ },
+ {
+ accessor: 'created_by',
+ disableSortBy: true,
+ Header: t('Created By'),
+ Cell: ({
+ row: {
+ original: { created_by: createdBy },
+ },
+ }: any) =>
+ createdBy ? `${createdBy.first_name} ${createdBy.last_name}` : '',
+ size: 'xl',
+ },
+ {
+ Cell: ({
+ row: {
+ original: { changed_on_delta_humanized: changedOn },
+ },
+ }: any) => changedOn,
+ Header: t('Last Modified'),
+ accessor: 'changed_on_delta_humanized',
+ size: 'xl',
+ },
+ {
+ Cell: ({ row: { original } }: any) => {
+ const handleEdit = () => {}; // handleDatabaseEdit(original);
+ const handleDelete = () => {}; // openDatabaseDeleteModal(original);
Review comment:
nit: incorrectly named and commented out code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11189: feat: CSS Templates List
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11189:
URL: https://github.com/apache/incubator-superset/pull/11189#issuecomment-705085376
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=h1) Report
> Merging [#11189](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `1.55%`.
> The diff coverage is `72.72%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11189/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 61.69% 60.14% -1.56%
==========================================
Files 828 392 -436
Lines 39116 24578 -14538
Branches 3688 0 -3688
==========================================
- Hits 24134 14782 -9352
+ Misses 14801 9796 -5005
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.14% <72.72%> (-1.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <72.72%> (-10.00%)` | :arrow_down: |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | `22.00% <0.00%> (-78.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.10% <0.00%> (-25.33%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-7.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.78% <0.00%> (-7.55%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11189/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=footer). Last update [13963ac...2debb94](https://codecov.io/gh/apache/incubator-superset/pull/11189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org