[GitHub] [airflow] Fokko commented on a change in pull request #5305: [AIRFLOW-986] HiveCliHook ignores 'proxy_user' value in a connection's extra parameter

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #5305: [AIRFLOW-986] HiveCliHook ignores 'proxy_user' value in a connection's extra parameter
URL: https://github.com/apache/airflow/pull/5305#discussion_r287770591
 
 

 ##########
 File path: airflow/hooks/hive_hooks.py
 ##########
 @@ -103,6 +103,21 @@ def __init__(
         self.mapred_queue_priority = mapred_queue_priority
         self.mapred_job_name = mapred_job_name
 
+    def _get_proxy_user(self):
+        """
+        This function set the proper proxy_user value in case the user overwtire the default.
+        """
+        conn = self.conn
+
+        proxy_user_value = conn.extra_dejson.get('proxy_user', "")  # noqa
 
 Review comment:
   Do we still need this `# noqa`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services