[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

[yifeih <gi...@git.apache.org>]

Github user yifeih commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22146#discussion_r211998423
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala ---
    @@ -96,3 +112,25 @@ private[spark] class KubernetesDriverBuilder(
         spec
       }
     }
    +
    +private[spark] object KubernetesDriverBuilder extends Logging {
    +  def apply(kubernetesClient: KubernetesClient, conf: SparkConf): KubernetesDriverBuilder = {
    +    conf.get(Config.KUBERNETES_DRIVER_PODTEMPLATE_FILE)
    +      .map(new File(_))
    +      .map(file => new KubernetesDriverBuilder(provideInitialSpec = conf => {
    +        try {
    +          val sparkPod = KubernetesUtils.loadPodFromTemplate(
    +            kubernetesClient,
    +            file,
    +            Constants.DRIVER_CONTAINER_NAME)
    --- End diff --
    
    They're not configurable currently. We should probably make them configurable since I'd imagine people would want to rely on these names being consistent


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org