You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/14 13:52:21 UTC
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10337: [Feature][Task Plugin]Enable users to switch and install conda env in jupyter task
zhongjiajie commented on code in PR #10337:
URL: https://github.com/apache/dolphinscheduler/pull/10337#discussion_r896848633
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterConstants.java:
##########
@@ -33,6 +33,18 @@ private JupyterConstants() {
*/
public static final String CONDA_ACTIVATE = "conda activate";
+ /**
+ * create and activate conda env from tar
+ */
+ public static final String CREATE_ENV_FROM_TAR = "mkdir jupyter_env && " +
+ "tar -xzf %s -C jupyter_env && " +
+ "source jupyter_env/bin/activate";
Review Comment:
> > It's better. But what i mean is if the user's the compressed tar package path after decompression is inconsistent with this hard code path.
>
> Seems if users use `conda pack` to pack their environment, when they run `tar` they will get the same directory structure. 
I test locally, and it is :+1:. but should we add some docs to tell use run `conda pack` to create the conda tarball?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org