[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #236: Add support for Link16 Charset 311:002

[GitBox <gi...@apache.org>]

bsloane1650 commented on a change in pull request #236: Add support for Link16 Charset 311:002
URL: https://github.com/apache/incubator-daffodil/pull/236#discussion_r294988714
 
 

 ##########
 File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/X_DFDL_MIL_STD.scala
 ##########
 @@ -15,6 +15,16 @@
  * limitations under the License.
  */
 
+/*
+ * This file contains special character encodings used by various US military data formats
+ * The DFI/DUI numbers may be used to lookup the definition of the encoding by those with access
+ * to the relevent specification. In cases where multiple DFI/DUI pairs make use of the same encoding,
+ * the decision of which pair to name the encoding after is arbitrary.
 
 Review comment:
   I do not believe that is possible.
   
   Many specifications (including all those I have access to) provide only a subset of all DFI/DUI pairs, so it is not possible to know what the lowest number DFI/DUI pair is. Even with access to the global dictionary, it is possible that a lower numbered one will be added in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services