[jira] Commented: (LOG4NET-107) [PATCH] Added ExceptionEvaluator

["Ron Grabowski (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/LOG4NET-107?page=comments#action_12459820 ] 
            
Ron Grabowski commented on LOG4NET-107:
---------------------------------------

Why isn't ExceptionType of type Exception:

/// <summary>
/// The type that triggers this evaluator.
/// </summary>
public Exception ExceptionType
{
	get { return m_type; }
	set { m_type = value; }
}

We know from the Exception property on LoggingEvent that the type must be at least Exception.

+1 for making the signature "public Exception ExceptionType".

> [PATCH] Added ExceptionEvaluator
> --------------------------------
>
>                 Key: LOG4NET-107
>                 URL: http://issues.apache.org/jira/browse/LOG4NET-107
>             Project: Log4net
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Drew Schaeffer
>         Assigned To: Ron Grabowski
>            Priority: Minor
>         Attachments: ExceptionEvaluator.cs, patch-file.diff
>
>
> Added an ExceptionEvaluator class to allow buffered appenders to trigger based on the type of LoggingEvent.ExceptionObject.  By setting the TiggerOnSubclass property the evaluator will trigger on types that are of the same type or subclasses of ExceptionType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira