You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4cxx-dev@logging.apache.org by Rhys Ulerich <rh...@gmail.com> on 2014/03/11 22:36:49 UTC

Oddness in Logger::getName() return value

Any one know why

    const LogString Logger::getName() const { return name; }

within src/main/include/log4cxx/logger.h doesn't return a const reference a la

    const LogString& Logger::getName() const { return name; }

In src/main/include/log4cxx/logstring.h the typedef is just

    typedef std::basic_string<logchar> LogString

which makes me think getName() invocations do needless copying, and
callers are already not permitted to mutate the result.

Any complaints if I change this?

- Rhys

Re: Oddness in Logger::getName() return value

Posted by Thorsten Schöning <ts...@am-soft.de>.

Guten Tag Rhys Ulerich,
am Dienstag, 11. März 2014 um 22:36 schrieben Sie:

> Any complaints if I change this?

No, looks like as simple typo.

Mit freundlichen Grüßen,

Thorsten Schöning

-- 
Thorsten Schöning       E-Mail:Thorsten.Schoening@AM-SoFT.de
AM-SoFT IT-Systeme      http://www.AM-SoFT.de/

Telefon...........05151-  9468- 55
Fax...............05151-  9468- 88
Mobil..............0178-8 9468- 04

AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow