[GitHub] [cordova-plugin-test-framework] svenemtell opened a new pull request #45: New jasmine version

[GitBox <gi...@apache.org>]

svenemtell opened a new pull request #45: New jasmine version
URL: https://github.com/apache/cordova-plugin-test-framework/pull/45
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   All platforms
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   #44 Makes it possible to write async tests not only using callbacks, but also using promises and async/await.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   I made these changes:
   1. Replaced assets/jasmine-2.4.1 with jasmine standalone 2.99.0 found here https://github.com/jasmine/jasmine/releases/tag/v2.99.0. It was the latest 2.x version having a standalone by the way.
   2. Searched and replaced jasmine-2.4.1 with jasmine-2.99.0.
   3. Updated README.md.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   I haven't found any test cases in cordova-plugin-test-framework so I have just tested running cordova-paramedic (using cordova-plugin-test-framework with these changes) on a cordova plugin of mine.   
   When running "npm test" it still complains about lots of linting errors, just like before this change.
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org