You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by to...@apache.org on 2014/01/21 21:09:14 UTC
[1/2] git commit: Adding/Removing instances from targetpool requires
a list. This fixes a bug with attaching/detaching nodes from loadbalancers.
(Attach/Detach wasn't working)
Updated Branches:
refs/heads/trunk b6f0ce88e -> 7fc910a88
Adding/Removing instances from targetpool requires a list. This fixes a bug with attaching/detaching nodes from loadbalancers. (Attach/Detach wasn't working)
Closes #228.
Signed-off-by: Tomaz Muraus <to...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/58f3722b
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/58f3722b
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/58f3722b
Branch: refs/heads/trunk
Commit: 58f3722ba54dc79cc9ef40271f6a3d39d6e8841d
Parents: b6f0ce8
Author: Rick Wright <ri...@google.com>
Authored: Tue Jan 21 11:43:01 2014 -0800
Committer: Tomaz Muraus <to...@apache.org>
Committed: Tue Jan 21 21:08:32 2014 +0100
----------------------------------------------------------------------
libcloud/compute/drivers/gce.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/libcloud/blob/58f3722b/libcloud/compute/drivers/gce.py
----------------------------------------------------------------------
diff --git a/libcloud/compute/drivers/gce.py b/libcloud/compute/drivers/gce.py
index 93fd2da..84bf7a2 100644
--- a/libcloud/compute/drivers/gce.py
+++ b/libcloud/compute/drivers/gce.py
@@ -1517,7 +1517,7 @@ class GCENodeDriver(NodeDriver):
if not hasattr(node, 'name'):
node = self.ex_get_node(node, 'all')
- targetpool_data = {'instance': node.extra['selfLink']}
+ targetpool_data = {'instances': [{'instance': node.extra['selfLink']}]}
request = '/regions/%s/targetPools/%s/addInstance' % (
targetpool.region.name, targetpool.name)
@@ -1571,7 +1571,7 @@ class GCENodeDriver(NodeDriver):
if not hasattr(node, 'name'):
node = self.ex_get_node(node, 'all')
- targetpool_data = {'instance': node.extra['selfLink']}
+ targetpool_data = {'instances': [{'instance': node.extra['selfLink']}]}
request = '/regions/%s/targetPools/%s/removeInstance' % (
targetpool.region.name, targetpool.name)
[2/2] git commit: Update CHANGES.
Posted by to...@apache.org.
Update CHANGES.
Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/7fc910a8
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/7fc910a8
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/7fc910a8
Branch: refs/heads/trunk
Commit: 7fc910a88fe1d0162be00c186ec76a997631607f
Parents: 58f3722
Author: Tomaz Muraus <to...@apache.org>
Authored: Tue Jan 21 21:08:57 2014 +0100
Committer: Tomaz Muraus <to...@apache.org>
Committed: Tue Jan 21 21:08:57 2014 +0100
----------------------------------------------------------------------
CHANGES.rst | 7 +++++++
1 file changed, 7 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/libcloud/blob/7fc910a8/CHANGES.rst
----------------------------------------------------------------------
diff --git a/CHANGES.rst b/CHANGES.rst
index 13acc40..80710bd 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,13 @@ Changelog
Changes with Apache Libcloud in development
-------------------------------------------
+Load Balancer
+~~~~~~~~~~~~~
+
+- Fix a bug in the ex_targetpool_add_node and ex_targetpool_remove_node method
+ in the GCE driver.
+ [Rick Wright]
+
DNS
~~~