You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/31 14:11:53 UTC
[GitHub] redsanket commented on a change in pull request #23700:
[SPARK-25692] [CORE] Remove static initialization of worker eventLoop
handling chunk fetch requests within TransportContext. This fixes
ChunkFetchIntegrationSuite as well
redsanket commented on a change in pull request #23700: [SPARK-25692] [CORE] Remove static initialization of worker eventLoop handling chunk fetch requests within TransportContext. This fixes ChunkFetchIntegrationSuite as well
URL: https://github.com/apache/spark/pull/23700#discussion_r252681476
##########
File path: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java
##########
@@ -88,7 +88,7 @@
// Separate thread pool for handling ChunkFetchRequest. This helps to enable throttling
// max number of TransportServer worker threads that are blocked on writing response
// of ChunkFetchRequest message back to the client via the underlying channel.
- private static EventLoopGroup chunkFetchWorkers;
+ private EventLoopGroup chunkFetchWorkers;
Review comment:
yes makes sense to make it final thanks will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org