You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2015/04/06 21:41:07 UTC
svn commit: r1671669 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java

Author: britter
Date: Mon Apr  6 19:41:06 2015
New Revision: 1671669

URL: http://svn.apache.org/r1671669
Log:
PMD: Useless parentheses

Modified:
    commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java?rev=1671669&r1=1671668&r2=1671669&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java Mon Apr  6 19:41:06 2015
@@ -409,9 +409,9 @@ public class EqualsBuilder implements Bu
             for (int i = 0; i < fields.length && builder.isEquals; i++) {
                 final Field f = fields[i];
                 if (!ArrayUtils.contains(excludeFields, f.getName())
-                    && (!f.getName().contains("$"))
+                    && !f.getName().contains("$")
                     && (useTransients || !Modifier.isTransient(f.getModifiers()))
-                    && (!Modifier.isStatic(f.getModifiers()))) {
+                    && !Modifier.isStatic(f.getModifiers())) {
                     try {
                         builder.append(f.get(lhs), f.get(rhs));
                     } catch (final IllegalAccessException e) {
@@ -512,7 +512,7 @@ public class EqualsBuilder implements Bu
         if (isEquals == false) {
             return this;
         }
-        isEquals = (lhs == rhs);
+        isEquals = lhs == rhs;
         return this;
     }
 
@@ -527,7 +527,7 @@ public class EqualsBuilder implements Bu
         if (isEquals == false) {
             return this;
         }
-        isEquals = (lhs == rhs);
+        isEquals = lhs == rhs;
         return this;
     }
 
@@ -542,7 +542,7 @@ public class EqualsBuilder implements Bu
         if (isEquals == false) {
             return this;
         }
-        isEquals = (lhs == rhs);
+        isEquals = lhs == rhs;
         return this;
     }
 
@@ -557,7 +557,7 @@ public class EqualsBuilder implements Bu
         if (isEquals == false) {
             return this;
         }
-        isEquals = (lhs == rhs);
+        isEquals = lhs == rhs;
         return this;
     }
 
@@ -572,7 +572,7 @@ public class EqualsBuilder implements Bu
         if (isEquals == false) {
             return this;
         }
-        isEquals = (lhs == rhs);
+        isEquals = lhs == rhs;
         return this;
     }
 
@@ -627,7 +627,7 @@ public class EqualsBuilder implements Bu
         if (isEquals == false) {
             return this;
         }
-        isEquals = (lhs == rhs);
+        isEquals = lhs == rhs;
         return this;
     }