You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Mike May <th...@gmail.com> on 2012/02/24 21:45:19 UTC

Review Request: getGroups does not throw a ProtocolException

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4043/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

getGroups should throw a ProtocolException 


This addresses bug SHINDIG-1713.
    https://issues.apache.org/jira/browse/SHINDIG-1713


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupService.java 1293307 

Diff: https://reviews.apache.org/r/4043/diff


Testing
-------


Thanks,

Mike

Re: Review Request: getGroups does not throw a ProtocolException

Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4043/#review5334
-----------------------------------------------------------

Ship it!


+1

Please also attach the patch to the JIRA case

- Henry


On 2012-02-24 20:47:03, Mike May wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4043/
> -----------------------------------------------------------
> 
> (Updated 2012-02-24 20:47:03)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> getGroups should throw a ProtocolException 
> 
> 
> This addresses bug SHINDIG-1713.
>     https://issues.apache.org/jira/browse/SHINDIG-1713
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupService.java 1293307 
> 
> Diff: https://reviews.apache.org/r/4043/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike
> 
>

Re: Review Request: getGroups does not throw a ProtocolException

Posted by Mike May <th...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4043/
-----------------------------------------------------------

(Updated 2012-02-24 20:47:03.132210)


Review request for shindig.


Changes
-------

Removed whitespace


Summary
-------

getGroups should throw a ProtocolException 


This addresses bug SHINDIG-1713.
    https://issues.apache.org/jira/browse/SHINDIG-1713


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupService.java 1293307 

Diff: https://reviews.apache.org/r/4043/diff


Testing
-------


Thanks,

Mike