[jira] [Commented] (CLOUDSTACK-7195) security_group.py should log exceptions instead of discarding them

["Vincent Bernat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-7195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076543#comment-14076543 ] 

Vincent Bernat commented on CLOUDSTACK-7195:
--------------------------------------------

A first step here: https://reviews.apache.org/r/23991/

Most try/except should only catch CalledProcessError. It would be easy to catch an unwanted exception otherwise...

> security_group.py should log exceptions instead of discarding them
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7195
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7195
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: 4.3.0
>            Reporter: Vincent Bernat
>
> security_group.py discards exceptions with a vague message. This is troublesome and hide some other bugs. See for example CLOUDSTACK-7193. Any try/except should at least log the exception.



--
This message was sent by Atlassian JIRA
(v6.2#6252)