[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.

["Appy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999355#comment-14999355 ] 

Appy commented on HBASE-14793:
------------------------------

[~eclark], how do you plan to use the new variable 'maxBlockSize'?

Btw, there's an incomplete log message here. Also, please consider writing a comment about why 12MB was chosen.
{code:java}
+
+    if (buf.heapSize() > 12 * 1024 * 1024) {
+      LOG.warn("Trying to cache too large a ");
+    }
+
{code}

> Allow limiting size of block into L1 block cache.
> -------------------------------------------------
>
>                 Key: HBASE-14793
>                 URL: https://issues.apache.org/jira/browse/HBASE-14793
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.1.2
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the size of a block that can be kept in the block cache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)