[GitHub] [incubator-paimon] FangYongs commented on a diff in pull request #775: [flink] support tables inherit not built-in configurations from catalog

["FangYongs (via GitHub)" <gi...@apache.org>]

FangYongs commented on code in PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#discussion_r1153915882


##########
paimon-common/src/main/java/org/apache/paimon/options/CatalogOptions.java:
##########
@@ -75,4 +77,18 @@ public class CatalogOptions {
                     .defaultValue(true)
                     .withDescription(
                             "Allow to fallback to hadoop File IO when no file io found for the scheme.");
+
+    public static final Set<String> PAIMON_CATALOG_OPTIONS =
+            new HashSet<String>() {
+                {
+                    add(WAREHOUSE.key());
+                    add(METASTORE.key());
+                    add(URI.key());
+                    add(TABLE_TYPE.key());
+                    add(LOCK_ENABLED.key());
+                    add(LOCK_CHECK_MAX_SLEEP.key());
+                    add(LOCK_ACQUIRE_TIMEOUT.key());
+                    add(FS_ALLOW_HADOOP_FALLBACK.key());
+                }

Review Comment:
   Can we get all fields from `CatalogOptions` instead of add them manually? Such as `FlinkConnectorOptions#getOptions`, we can add a tool class for them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org