You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/05/13 03:55:15 UTC
Review Request 34150: SQOOP-2356: Sqoop2: Derby upgrade should
automatically rename jobs that have conflicting names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34150/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2356
https://issues.apache.org/jira/browse/SQOOP-2356
Repository: sqoop-sqoop2
Description
-------
commit 3209294cdfb5335c6920ffb11b6f5a721f43baa9
Author: Abraham Elmahrek <ab...@apache.org>
Date: Tue May 12 17:30:14 2015 -0700
SQOOP-2356: Sqoop2: Derby upgrade should automatically rename jobs that have conflicting names
:100644 100644 96438d6... 73293c0... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
:100644 100644 96fba2c... 774c3b4... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
:100644 100644 5c247e1... 2ba3384... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 bcdb8d8... b81f81c... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
:000000 100644 0000000... 812c2af... A repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java
:100644 100644 849ab7b... 830470d... M test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java
:100644 100644 bf9bf85... 790d304... M test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz
Diffs
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java 96438d6
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 96fba2c
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5c247e1
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java bcdb8d8
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java 849ab7b
test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz bf9bf85
Diff: https://reviews.apache.org/r/34150/diff/
Testing
-------
Added new tests
Thanks,
Abraham Elmahrek
Re: Review Request 34150: SQOOP-2356: Sqoop2: Derby upgrade should
automatically rename jobs that have conflicting names
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On May 13, 2015, 8:25 a.m., Qian Xu wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java, line 123
> > <https://reviews.apache.org/r/34150/diff/2/?file=957974#file957974line123>
> >
> > I'm not good at math. 64-48=16. Is the length of UUID 36 (32 hex plus 4 dashes)? Better define max and calculate the max free length for name prefix.
16 * 8 = 128. 128 bits: https://docs.oracle.com/javase/7/docs/api/java/util/UUID.html. Good point though. Will do max of suffix and append.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34150/#review83575
-----------------------------------------------------------
On May 13, 2015, 5:29 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34150/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 5:29 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2356
> https://issues.apache.org/jira/browse/SQOOP-2356
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 3209294cdfb5335c6920ffb11b6f5a721f43baa9
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Tue May 12 17:30:14 2015 -0700
>
> SQOOP-2356: Sqoop2: Derby upgrade should automatically rename jobs that have conflicting names
>
> :100644 100644 96438d6... 73293c0... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
> :100644 100644 96fba2c... 774c3b4... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
> :100644 100644 5c247e1... 2ba3384... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 bcdb8d8... b81f81c... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
> :000000 100644 0000000... 812c2af... A repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java
> :100644 100644 849ab7b... 830470d... M test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java
> :100644 100644 bf9bf85... 790d304... M test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java 96438d6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 96fba2c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5c247e1
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java bcdb8d8
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java 849ab7b
> test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz bf9bf85
>
> Diff: https://reviews.apache.org/r/34150/diff/
>
>
> Testing
> -------
>
> Added new tests
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 34150: SQOOP-2356: Sqoop2: Derby upgrade should
automatically rename jobs that have conflicting names
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34150/#review83575
-----------------------------------------------------------
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java
<https://reviews.apache.org/r/34150/#comment134582>
I'm not good at math. 64-48=16. Is the length of UUID 36 (32 hex plus 4 dashes)? Better define max and calculate the max free length for name prefix.
- Qian Xu
On May 13, 2015, 1:29 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34150/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 1:29 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2356
> https://issues.apache.org/jira/browse/SQOOP-2356
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 3209294cdfb5335c6920ffb11b6f5a721f43baa9
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Tue May 12 17:30:14 2015 -0700
>
> SQOOP-2356: Sqoop2: Derby upgrade should automatically rename jobs that have conflicting names
>
> :100644 100644 96438d6... 73293c0... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
> :100644 100644 96fba2c... 774c3b4... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
> :100644 100644 5c247e1... 2ba3384... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 bcdb8d8... b81f81c... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
> :000000 100644 0000000... 812c2af... A repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java
> :100644 100644 849ab7b... 830470d... M test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java
> :100644 100644 bf9bf85... 790d304... M test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java 96438d6
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 96fba2c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5c247e1
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java bcdb8d8
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java 849ab7b
> test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz bf9bf85
>
> Diff: https://reviews.apache.org/r/34150/diff/
>
>
> Testing
> -------
>
> Added new tests
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 34150: SQOOP-2356: Sqoop2: Derby upgrade should
automatically rename jobs that have conflicting names
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34150/#review83904
-----------------------------------------------------------
Ship it!
LGTM.
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
<https://reviews.apache.org/r/34150/#comment134984>
nice cleanup.
- Gwen Shapira
On May 13, 2015, 6:31 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34150/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 6:31 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2356
> https://issues.apache.org/jira/browse/SQOOP-2356
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 3209294cdfb5335c6920ffb11b6f5a721f43baa9
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Tue May 12 17:30:14 2015 -0700
>
> SQOOP-2356: Sqoop2: Derby upgrade should automatically rename jobs that have conflicting names
>
> :100644 100644 96438d6... 73293c0... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
> :100644 100644 96fba2c... 774c3b4... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
> :100644 100644 5c247e1... 2ba3384... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 bcdb8d8... b81f81c... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
> :000000 100644 0000000... 812c2af... A repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java
> :100644 100644 849ab7b... 830470d... M test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java
> :100644 100644 bf9bf85... 790d304... M test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java 96438d633ec6b5e54f26e220beb45a14883a7120
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 96fba2c20aaa86228fc4fafa7113e64f3092bf6a
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5c247e1f83325dff6400b688a905c31562dd4e41
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java bcdb8d888aaf525689bc9af788ae2bd50fb6b9f7
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java 849ab7b6f3f5113107b8de08a31fa32f75b39e6a
> test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz bf9bf853e0f5a489058668e3bb0a3e1146b2d860
>
> Diff: https://reviews.apache.org/r/34150/diff/
>
>
> Testing
> -------
>
> Added new tests
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 34150: SQOOP-2356: Sqoop2: Derby upgrade should
automatically rename jobs that have conflicting names
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34150/
-----------------------------------------------------------
(Updated May 13, 2015, 6:31 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2356
https://issues.apache.org/jira/browse/SQOOP-2356
Repository: sqoop-sqoop2
Description
-------
commit 3209294cdfb5335c6920ffb11b6f5a721f43baa9
Author: Abraham Elmahrek <ab...@apache.org>
Date: Tue May 12 17:30:14 2015 -0700
SQOOP-2356: Sqoop2: Derby upgrade should automatically rename jobs that have conflicting names
:100644 100644 96438d6... 73293c0... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
:100644 100644 96fba2c... 774c3b4... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
:100644 100644 5c247e1... 2ba3384... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 bcdb8d8... b81f81c... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
:000000 100644 0000000... 812c2af... A repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java
:100644 100644 849ab7b... 830470d... M test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java
:100644 100644 bf9bf85... 790d304... M test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz
Diffs (updated)
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java 96438d633ec6b5e54f26e220beb45a14883a7120
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 96fba2c20aaa86228fc4fafa7113e64f3092bf6a
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5c247e1f83325dff6400b688a905c31562dd4e41
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java bcdb8d888aaf525689bc9af788ae2bd50fb6b9f7
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java 849ab7b6f3f5113107b8de08a31fa32f75b39e6a
test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz bf9bf853e0f5a489058668e3bb0a3e1146b2d860
Diff: https://reviews.apache.org/r/34150/diff/
Testing
-------
Added new tests
Thanks,
Abraham Elmahrek
Re: Review Request 34150: SQOOP-2356: Sqoop2: Derby upgrade should
automatically rename jobs that have conflicting names
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34150/
-----------------------------------------------------------
(Updated May 13, 2015, 5:29 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2356
https://issues.apache.org/jira/browse/SQOOP-2356
Repository: sqoop-sqoop2
Description
-------
commit 3209294cdfb5335c6920ffb11b6f5a721f43baa9
Author: Abraham Elmahrek <ab...@apache.org>
Date: Tue May 12 17:30:14 2015 -0700
SQOOP-2356: Sqoop2: Derby upgrade should automatically rename jobs that have conflicting names
:100644 100644 96438d6... 73293c0... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java
:100644 100644 96fba2c... 774c3b4... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
:100644 100644 5c247e1... 2ba3384... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 bcdb8d8... b81f81c... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
:000000 100644 0000000... 812c2af... A repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java
:100644 100644 849ab7b... 830470d... M test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java
:100644 100644 bf9bf85... 790d304... M test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz
Diffs (updated)
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java 96438d6
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 96fba2c
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5c247e1
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java bcdb8d8
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/upgrade/UniqueJobRename.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java 849ab7b
test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz bf9bf85
Diff: https://reviews.apache.org/r/34150/diff/
Testing
-------
Added new tests
Thanks,
Abraham Elmahrek