You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "aswathitv (via GitHub)" <gi...@apache.org> on 2025/07/24 11:46:07 UTC
[PR] kie-issues#891: DMN Editor: Removing a Decision from a Decision Service [incubator-kie-tools]
aswathitv opened a new pull request, #3211:
URL: https://github.com/apache/incubator-kie-tools/pull/3211
Closes [kie#891](https://github.com/apache/incubator-kie-issues/issues/891)
- Dragging a decision out from a decision service removes it from all DRDs that contains the decision service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#891: DMN Editor: Removing a Decision from a Decision Service [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3211:
URL: https://github.com/apache/incubator-kie-tools/pull/3211#discussion_r2231810415
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -918,6 +918,32 @@ export const Diagram = React.forwardRef<DiagramRef, { container: React.RefObject
dsShape["dc:Bounds"]["@_y"] =
(parentShape["dc:Bounds"]?.["@_y"] ?? 0) + relativePosinCurrentDS.y;
}
+ // Remove decision from decision service
+ let isInside = true;
Review Comment:
I don't think you need to check whether the Decision node is visually inside the Decision Service, as when the Decision Service is not in a collapsed state you can assume the Decision being present in the DRD means it now needs to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#891: DMN Editor: Removing a Decision from a Decision Service [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #3211:
URL: https://github.com/apache/incubator-kie-tools/pull/3211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#891: DMN Editor: Removing a Decision from a Decision Service [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3211:
URL: https://github.com/apache/incubator-kie-tools/pull/3211#discussion_r2248729431
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -918,6 +918,32 @@ export const Diagram = React.forwardRef<DiagramRef, { container: React.RefObject
dsShape["dc:Bounds"]["@_y"] =
(parentShape["dc:Bounds"]?.["@_y"] ?? 0) + relativePosinCurrentDS.y;
}
+ // Remove decision from decision service
+ let isInside = true;
Review Comment:
Right, what was strange to me is that you're checking whether the Decision `isInside` for every single DRD. But I guess because the depiction is consistent across all DRDs, this won't fail, just some extra checks. I'm ok with this. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#891: DMN Editor: Removing a Decision from a Decision Service [incubator-kie-tools]
Posted by "aswathitv (via GitHub)" <gi...@apache.org>.
aswathitv commented on code in PR #3211:
URL: https://github.com/apache/incubator-kie-tools/pull/3211#discussion_r2241699589
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -918,6 +918,32 @@ export const Diagram = React.forwardRef<DiagramRef, { container: React.RefObject
dsShape["dc:Bounds"]["@_y"] =
(parentShape["dc:Bounds"]?.["@_y"] ?? 0) + relativePosinCurrentDS.y;
}
+ // Remove decision from decision service
+ let isInside = true;
Review Comment:
Checking if inside to make sure the movement of contained decision is not within the decision service and to make sure it is moving out like removing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org