You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Lai <ja...@jasonlai.net> on 2018/02/27 19:05:09 UTC
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
-----------------------------------------------------------
(Updated Feb. 27, 2018, 7:05 p.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Summary (updated)
-----------------
Added an overloaded version of `os::realpath` to stout
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description (updated)
-------
Added an overloaded version of `os::realpath` to stout.
The new `os::realpath` function is used for evaluating real path
within a scoped root directory.
Diffs
-----
3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/2/
Testing
-------
Thanks,
Jason Lai
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review198342
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65811', '65812']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812
Relevant logs:
- [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812/logs/stout-tests-cmake-stdout.log):
```
CUSTOMBUILD : CMake warning : [D:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj" (default target) (7) ->
CUSTOMBUILD : CMake warning : [D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj]
"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
(Link target) ->
ip_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
mac_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
main.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
os_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
path_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
subcommand_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
copyfile_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
env_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
filesystem_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
process_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
rmdir_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
socket_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
strerror_tests.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in flags_tests.obj [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
D:\DCOS\mesos\3rdparty\stout\tests\Debug\stout-tests.exe : fatal error LNK1169: one or more multiply defined symbols found [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
114 Warning(s)
14 Error(s)
Time Elapsed 00:04:26.09
```
- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812/logs/libprocess-tests-cmake-stdout.log):
```
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (5) ->
process.lib(clock.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(process.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(pid.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(latch.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(http.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(time.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(libevent.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(socket.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(help.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(logging.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(profiler.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(reap.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(metrics.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(openssl.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(authenticator_manager.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(http_proxy.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(libevent_ssl_socket.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(poll_socket.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(libevent_poll.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
process.lib(io.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in benchmarks.obj [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
D:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\benchmarks.exe : fatal error LNK1169: one or more multiply defined symbols found [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
49 Warning(s)
63 Error(s)
Time Elapsed 00:06:01.98
```
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812/logs/mesos-tests-cmake-stdout.log):
```
test_helper_main.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
utils.obj : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
mesos.lib(compatibility.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(process.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(pid.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(clock.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(latch.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(socket.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(http.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(time.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(help.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(logging.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(profiler.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(reap.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(metrics.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(openssl.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(authenticator_manager.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(libevent.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(http_proxy.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(libevent_ssl_socket.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(poll_socket.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(libevent_poll.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
process.lib(io.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl path::clean(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,char)" (?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z) already defined in active_user_test_helper.obj [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
D:\DCOS\mesos\src\test-helper.exe : fatal error LNK1169: one or more multiply defined symbols found [D:\DCOS\mesos\src\tests\test-helper.vcxproj]
220 Warning(s)
158 Error(s)
Time Elapsed 00:23:21.82
```
- Mesos Reviewbot Windows
On Feb. 27, 2018, 7:05 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2018, 7:05 p.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review198552
-----------------------------------------------------------
PASS: Mesos patch 65812 was successfully built and tested.
Reviews applied: `['65811', '65812']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812
- Mesos Reviewbot Windows
On March 2, 2018, 7:41 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 7:41 p.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203454
-----------------------------------------------------------
It's very hard to reason about the correctness of this patch without seeing thorough testing. Please include tests!
- Jie Yu
On May 17, 2018, 1:07 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 1:07 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line51>
> >
> > Any reason we need this parameter here? Can we just remove this parameter, and use `os::PATH_SEPARATOR` below?
Done.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line65>
> >
> > No need for period for error messages.
Done
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 88 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line88>
> >
> > No need to specify `_separator`?
Dropped.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 99 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line99>
> >
> > no need to specify `_separator` for both functions. They're the default value
Dropped.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 108-112 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line108>
> >
> > Let's add a stout helper `os::readlink`:
> >
> > ```
> > Try<string> readlink(const string& path);
> > ```
I added https://reviews.apache.org/r/68804/ as the wrapper for this.
> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 130 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line130>
> >
> > Ditto. No need for `_separator`
Dropped.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203430
-----------------------------------------------------------
On May 17, 2018, 1:07 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 1:07 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203430
-----------------------------------------------------------
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 51 (patched)
<https://reviews.apache.org/r/65812/#comment285647>
Any reason we need this parameter here? Can we just remove this parameter, and use `os::PATH_SEPARATOR` below?
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 65 (patched)
<https://reviews.apache.org/r/65812/#comment285648>
No need for period for error messages.
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 88 (patched)
<https://reviews.apache.org/r/65812/#comment285678>
No need to specify `_separator`?
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 98-99 (patched)
<https://reviews.apache.org/r/65812/#comment285685>
Hum, consider this case:
```
path="/rootfs/bar"
root="/rootfs"
```
I was expecting the correct result to be `"/rootfs/bar"` (if I understand your function parameter correctly, if not, can you add more description for the parameters?)
Assuming that there's a symlink in the rootfs `/rootfs/rootfs -> /foo` (symlink).
When we process `"rootfs"` here (i.e., `component`), `normalizedPath == "/rootfs"`, and `fullPath == "/rootfs/rootfs"`. Since `/rootfs/rootfs` is a symlink, `linkPath` will be `"/foo"`. `"unprocessed"` will become `"/foo/bar"`.
Maybe the parameter `path` is scoped in the `root`? If that's the case, can you improve the function comments with more examples?
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 99 (patched)
<https://reviews.apache.org/r/65812/#comment285681>
no need to specify `_separator` for both functions. They're the default value
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 102-107 (patched)
<https://reviews.apache.org/r/65812/#comment285682>
you can use `os::stat::islink` here
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 108-112 (patched)
<https://reviews.apache.org/r/65812/#comment285683>
Let's add a stout helper `os::readlink`:
```
Try<string> readlink(const string& path);
```
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 130 (patched)
<https://reviews.apache.org/r/65812/#comment285679>
Ditto. No need for `_separator`
- Jie Yu
On May 17, 2018, 1:07 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 1:07 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
> On May 18, 2018, 10:12 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 68-81 (patched)
> > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line68>
> >
> > IN fact, I would consider making `unprocessed` a `vector<string>` (which is a result of `tokenize`)
> >
> > I understand you want to reset `unprocessed` below, you can still do one more `tokenize` there to avoid the complex substr logic here.
I tried with a local rewritten version per your suggestion, but it actually turned out to be a bit more complex and added perf overhead to this version.
We simply need to split `unprocessed` into 0 up to 2 elements and the logic seems pretty intuitive here.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203455
-----------------------------------------------------------
On May 17, 2018, 1:07 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 1:07 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203455
-----------------------------------------------------------
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 68-81 (patched)
<https://reviews.apache.org/r/65812/#comment285687>
IN fact, I would consider making `unprocessed` a `vector<string>` (which is a result of `tokenize`)
I understand you want to reset `unprocessed` below, you can still do one more `tokenize` there to avoid the complex substr logic here.
- Jie Yu
On May 17, 2018, 1:07 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 1:07 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
-----------------------------------------------------------
(Updated Nov. 7, 2018, 9:23 p.m.)
Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Rebased to master
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added an overloaded version of `os::realpath` to stout.
The new `os::realpath` function is used for evaluating real path
within a scoped root directory.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/8/
Changes: https://reviews.apache.org/r/65812/diff/7-8/
Testing
-------
Thanks,
Jason Lai
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
-----------------------------------------------------------
(Updated Sept. 21, 2018, 10:45 p.m.)
Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Address review comments from @jieyu.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added an overloaded version of `os::realpath` to stout.
The new `os::realpath` function is used for evaluating real path
within a scoped root directory.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/7/
Changes: https://reviews.apache.org/r/65812/diff/6-7/
Testing
-------
Thanks,
Jason Lai
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
-----------------------------------------------------------
(Updated May 17, 2018, 1:07 a.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Rebased to the latest `master` branch.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added an overloaded version of `os::realpath` to stout.
The new `os::realpath` function is used for evaluating real path
within a scoped root directory.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/6/
Changes: https://reviews.apache.org/r/65812/diff/5-6/
Testing
-------
Thanks,
Jason Lai
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
-----------------------------------------------------------
(Updated May 8, 2018, 6:43 p.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Rename `path::clean` to `path::normalize`.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added an overloaded version of `os::realpath` to stout.
The new `os::realpath` function is used for evaluating real path
within a scoped root directory.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/5/
Changes: https://reviews.apache.org/r/65812/diff/4-5/
Testing
-------
Thanks,
Jason Lai
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
> On March 16, 2018, 11:20 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 48 (patched)
> > <https://reviews.apache.org/r/65812/diff/4/?file=1970034#file1970034line48>
> >
> > Please add unit test for this.
Will do in a separate patch.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review199365
-----------------------------------------------------------
On March 5, 2018, 7:29 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated March 5, 2018, 7:29 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review199365
-----------------------------------------------------------
3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 48 (patched)
<https://reviews.apache.org/r/65812/#comment279674>
Please add unit test for this.
- Jie Yu
On March 5, 2018, 7:29 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated March 5, 2018, 7:29 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
-----------------------------------------------------------
(Updated March 5, 2018, 7:29 a.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Add `static` to the constant of `MAX_SYMLINKS`.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added an overloaded version of `os::realpath` to stout.
The new `os::realpath` function is used for evaluating real path
within a scoped root directory.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/4/
Changes: https://reviews.apache.org/r/65812/diff/3-4/
Testing
-------
Thanks,
Jason Lai
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review198579
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65811, 65812]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 2, 2018, 7:41 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 7:41 p.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an overloaded version of `os::realpath` to stout.
>
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
>
>
> Diff: https://reviews.apache.org/r/65812/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65812: Added an overloaded version of
`os::realpath` to stout
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
-----------------------------------------------------------
(Updated March 2, 2018, 7:41 p.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Use `inline` for the overloaded `os::realpath`.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added an overloaded version of `os::realpath` to stout.
The new `os::realpath` function is used for evaluating real path
within a scoped root directory.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/realpath.hpp 31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/3/
Changes: https://reviews.apache.org/r/65812/diff/2-3/
Testing
-------
Thanks,
Jason Lai