You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by ptgoetz <gi...@git.apache.org> on 2016/01/05 04:41:45 UTC

[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/478#issuecomment-168884966
  
    I'm all for adopting a code style guide for all languages (Java, Clojure, Python, etc.), but I'd rather see a style specification documented first, then follow up with templates that implement it.
    
    I do feel that we have a lot of code style technical debt in both Java/Clojure. If we're moving away from clojure, we don't need to worry about style too much there, but we should establish a style guide for Java source, and start cleaning up compiler warnings, PMD/Checkstyle/Findbugs issues, etc.
    
    I would suggest a discussion on the dev@ list, and hope it doesn't become too religious. ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---