You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/11 04:24:50 UTC
[GitHub] [camel-karavan] mrinalsharma opened a new pull request, #524: Added support to flag components Red/Green when required properties a…
mrinalsharma opened a new pull request, #524:
URL: https://github.com/apache/camel-karavan/pull/524
I think we can use some better UI elements to Flag Proper setup. @mgubaidullin you can decide if the current Icons are good or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on pull request #524: Added support to flag components Red/Green when required properties a…
Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on PR #524:
URL: https://github.com/apache/camel-karavan/pull/524#issuecomment-1311748886
@mrinalsharma I disagree.
1. Small round elements on route diagram are buttons (grey to delete or blue to add smth)
2. If Element is properly configured it has normal dark grey color label
3. Additional round elements confuses.
4. If component/kamelet/dsl is not properly configured the label is red.
5. User should not be notified that everything is OK (green icon), It is enough to notify user that something is wrong.
<img width="696" alt="Screen Shot 2022-11-11 at 9 09 35 AM" src="https://user-images.githubusercontent.com/1379213/201357239-6b23e090-465f-4dad-9392-0143b924c18c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mrinalsharma commented on pull request #524: Added support to flag components Red/Green when required properties a…
Posted by GitBox <gi...@apache.org>.
mrinalsharma commented on PR #524:
URL: https://github.com/apache/camel-karavan/pull/524#issuecomment-1311892427
Thanks for the update, it seams you have already made changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mrinalsharma commented on pull request #524: Added support to flag components Red/Green when required properties a…
Posted by GitBox <gi...@apache.org>.
mrinalsharma commented on PR #524:
URL: https://github.com/apache/camel-karavan/pull/524#issuecomment-1311916287
Closing this pullrequest as Issue [494 ](https://github.com/apache/camel-karavan/issues/494)is already resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mrinalsharma closed pull request #524: Added support to flag components Red/Green when required properties a…
Posted by GitBox <gi...@apache.org>.
mrinalsharma closed pull request #524: Added support to flag components Red/Green when required properties a…
URL: https://github.com/apache/camel-karavan/pull/524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org