[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30116: [SPARK-33202][CORE] Fix BlockManagerDecommissioner to return the correct migration status

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #30116:
URL: https://github.com/apache/spark/pull/30116#discussion_r509012589



##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##########
@@ -268,7 +268,7 @@ private[storage] class BlockManagerDecommissioner(
       stoppedShuffle = true
     }
     // If we found any new shuffles to migrate or otherwise have not migrated everything.
-    newShufflesToMigrate.nonEmpty || migratingShuffles.size < numMigratedShuffles.get()
+    newShufflesToMigrate.nonEmpty || migratingShuffles.size > numMigratedShuffles.get()

Review comment:
       This is the fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org