[GitHub] [arrow] mapleFU commented on a diff in pull request #34720: GH-34633: [C++][Parquet] Fix StreamReader to read decimals

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #34720:
URL: https://github.com/apache/arrow/pull/34720#discussion_r1147312516


##########
cpp/src/parquet/stream_reader_test.cc:
##########
@@ -912,5 +913,39 @@ TEST_F(TestReadingDataFiles, Int64Decimal) {
   EXPECT_EQ(i, 25);
 }
 
+TEST_F(TestReadingDataFiles, FLBADecimal) {
+  PARQUET_ASSIGN_OR_THROW(auto infile, ::arrow::io::ReadableFile::Open(
+                                           GetDataFile("fixed_length_decimal.parquet")));
+
+  auto file_reader = ParquetFileReader::Open(infile);
+  auto reader = StreamReader{std::move(file_reader)};
+
+  ::arrow::Decimal128 x;
+  int i;

Review Comment:
   `int i = 0;` to avoid reader already eof, and `i` is undefined?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org