You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/02/07 14:59:08 UTC
Review Request 17847: CLOUDSTACK-5978: Changes in get_template function to
make it independent of ostype passed through test case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17847/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-5978
https://issues.apache.org/jira/browse/CLOUDSTACK-5978
Repository: cloudstack-git
Description
-------
Some test cases are failing because the ostype passed to the get_template function is different in each test case and it fails whenever it does not match with the ostype of template in the CS setup. Changed get_template function so that ostype id does not have any effect on the returning data (It will always return the feature, built in template in the given zone which is in READY state). This way we eliminate the dependency between the test case and the CS setup.
This is the first set of change in marvin library. In next step, we can remove the hard coded ostype from all the test cases. For now, this is sufficient to save test cases from failing due to hard coded value.
Diffs
-----
tools/marvin/marvin/integration/lib/common.py 550de1a
Diff: https://reviews.apache.org/r/17847/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 17847: CLOUDSTACK-5978: Changes in get_template function
to make it independent of ostype passed through test case
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17847/#review34053
-----------------------------------------------------------
Commit 899ad1739359a4d851a033aa5743745199133494 in branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=899ad17 ]
CLOUDSTACK-5978: Changes in get_template function to make it
independent of ostype passed through test case
- ASF Subversion and Git Services
On Feb. 7, 2014, 1:59 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17847/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2014, 1:59 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5978
> https://issues.apache.org/jira/browse/CLOUDSTACK-5978
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some test cases are failing because the ostype passed to the get_template function is different in each test case and it fails whenever it does not match with the ostype of template in the CS setup. Changed get_template function so that ostype id does not have any effect on the returning data (It will always return the feature, built in template in the given zone which is in READY state). This way we eliminate the dependency between the test case and the CS setup.
>
> This is the first set of change in marvin library. In next step, we can remove the hard coded ostype from all the test cases. For now, this is sufficient to save test cases from failing due to hard coded value.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py 550de1a
>
> Diff: https://reviews.apache.org/r/17847/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17847: CLOUDSTACK-5978: Changes in get_template function
to make it independent of ostype passed through test case
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17847/#review34055
-----------------------------------------------------------
Committed to 4.3-forward and master
- Girish Shilamkar
On Feb. 7, 2014, 1:59 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17847/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2014, 1:59 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5978
> https://issues.apache.org/jira/browse/CLOUDSTACK-5978
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some test cases are failing because the ostype passed to the get_template function is different in each test case and it fails whenever it does not match with the ostype of template in the CS setup. Changed get_template function so that ostype id does not have any effect on the returning data (It will always return the feature, built in template in the given zone which is in READY state). This way we eliminate the dependency between the test case and the CS setup.
>
> This is the first set of change in marvin library. In next step, we can remove the hard coded ostype from all the test cases. For now, this is sufficient to save test cases from failing due to hard coded value.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py 550de1a
>
> Diff: https://reviews.apache.org/r/17847/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17847: CLOUDSTACK-5978: Changes in get_template function
to make it independent of ostype passed through test case
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17847/#review34054
-----------------------------------------------------------
Commit 675414feb8d7e15bb4a3251b922a1a1d10639cb0 in branch refs/heads/4.3-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=675414f ]
CLOUDSTACK-5978: Changes in get_template function to make it
independent of ostype passed through test case
- ASF Subversion and Git Services
On Feb. 7, 2014, 1:59 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17847/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2014, 1:59 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-5978
> https://issues.apache.org/jira/browse/CLOUDSTACK-5978
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some test cases are failing because the ostype passed to the get_template function is different in each test case and it fails whenever it does not match with the ostype of template in the CS setup. Changed get_template function so that ostype id does not have any effect on the returning data (It will always return the feature, built in template in the given zone which is in READY state). This way we eliminate the dependency between the test case and the CS setup.
>
> This is the first set of change in marvin library. In next step, we can remove the hard coded ostype from all the test cases. For now, this is sufficient to save test cases from failing due to hard coded value.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py 550de1a
>
> Diff: https://reviews.apache.org/r/17847/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>