You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/09 19:14:53 UTC
[GitHub] [trafficserver] SolidWallOfCode opened a new pull request #7264: HostDB: remove unused field in HostDBApplicationInfo
SolidWallOfCode opened a new pull request #7264:
URL: https://github.com/apache/trafficserver/pull/7264
* Remove `HostDBApplicationInfo::http_data::fail_timeout`.
* Change `HostDBApplicationInfo::HttpVersion` to be an 8 bit enum.
* Move the 32 bit value in `HostDBApplicationInfo::http_data` to be first for better packing.
* Add a `static_assert` to make sure the `allotment` member is sufficiently sized.
* Bump the HostDB object version to 1.1.
Ultimately this is about the first point, the others are collateral changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7264: HostDB: remove unused field in HostDBApplicationInfo
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7264:
URL: https://github.com/apache/trafficserver/pull/7264#issuecomment-709553881
Yes, it should. Updated the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall edited a comment on pull request #7264: HostDB: remove unused field in HostDBApplicationInfo
Posted by GitBox <gi...@apache.org>.
randall edited a comment on pull request #7264:
URL: https://github.com/apache/trafficserver/pull/7264#issuecomment-707888596
> Remove `HostDBApplicationInfo::http_data::fail_timeout`.
should this be keepalive_timeout ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode merged pull request #7264: HostDB: remove unused field in HostDBApplicationInfo
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode merged pull request #7264:
URL: https://github.com/apache/trafficserver/pull/7264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7264: HostDB: remove unused field in HostDBApplicationInfo
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7264:
URL: https://github.com/apache/trafficserver/pull/7264#issuecomment-707888596
> * Remove `HostDBApplicationInfo::http_data::fail_timeout`.
should this be keepalive_timeout ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org