You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by we...@apache.org on 2016/03/13 18:45:13 UTC
parquet-cpp git commit: PARQUET-561: Add destructor to PIMPL
Repository: parquet-cpp
Updated Branches:
refs/heads/master caf2576ce -> 86b016885
PARQUET-561: Add destructor to PIMPL
Without this destuctor, the SerializedFile class cannot be destructed and leaks memory.
Author: Uwe L. Korn <uw...@xhochy.com>
Closes #77 from xhochy/destructor-for-pimpl and squashes the following commits:
0f80966 [Uwe L. Korn] Add destructor to PIMPL
Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/86b01688
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/86b01688
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/86b01688
Branch: refs/heads/master
Commit: 86b0168859124df608c41c2d528d62fb85e31903
Parents: caf2576
Author: Uwe L. Korn <uw...@xhochy.com>
Authored: Sun Mar 13 10:44:54 2016 -0700
Committer: Wes McKinney <we...@apache.org>
Committed: Sun Mar 13 10:44:54 2016 -0700
----------------------------------------------------------------------
src/parquet/file/reader.h | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/86b01688/src/parquet/file/reader.h
----------------------------------------------------------------------
diff --git a/src/parquet/file/reader.h b/src/parquet/file/reader.h
index 94f5931..18b052a 100644
--- a/src/parquet/file/reader.h
+++ b/src/parquet/file/reader.h
@@ -69,6 +69,7 @@ class ParquetFileReader {
public:
// Forward declare the PIMPL
struct Contents {
+ virtual ~Contents() {}
// Perform any cleanup associated with the file contents
virtual void Close() = 0;