You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:53 UTC
[Impala-CR] IMPALA-3829: OpenSession() logs errors on valid configuration keys
Hello Michael Ho, Internal Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4226
to review the following change.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys
......................................................................
IMPALA-3829: OpenSession() logs errors on valid configuration keys
Refactored OpenSession() to process the supplied configuration
map in one loop. Call SetQueryOption() on normal configuration
keys only.
Other changes:
- Compare config keys to "impala.doas.user" in case-insensitive
manner.
- New E2E test to check that setting query options still works
after the change.
Change-Id: Ifa9b823abc39ba9809a35a6f0844fa3436f1e025
Reviewed-on: http://gerrit.cloudera.org:8080/3808
Tested-by: Internal Jenkins
Reviewed-by: Michael Ho <kw...@cloudera.com>
(cherry picked from commit 457ee684c8baee7ab0deff49e07c0d8dd5da370d)
---
M be/src/service/impala-hs2-server.cc
M tests/hs2/test_hs2.py
2 files changed, 39 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/26/4226/1
--
To view, visit http://gerrit.cloudera.org:8080/4226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa9b823abc39ba9809a35a6f0844fa3436f1e025
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-CR] IMPALA-3829: OpenSession() logs errors on valid configuration keys
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ifa9b823abc39ba9809a35a6f0844fa3436f1e025
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>