You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "John Thomas (Jira)" <ji...@apache.org> on 2020/07/28 04:10:00 UTC
[jira] [Commented] (KAFKA-10316) Consider renaming getter method
for Interactive Queries
[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166136#comment-17166136 ]
John Thomas commented on KAFKA-10316:
-------------------------------------
[~mjsax] Can I pick this up ?
* I understand that a KIP should be created.
* Add new methods in KeyQueryMetadata.java and mark old ones as deprecated.
* How about the occurrences of the existing methods in the unit tests ? Are unit tests still going to call the methods marked as deprecated ? (I'm a newbie, that's why this question).
> Consider renaming getter method for Interactive Queries
> -------------------------------------------------------
>
> Key: KAFKA-10316
> URL: https://issues.apache.org/jira/browse/KAFKA-10316
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Priority: Minor
> Labels: beginner, need-kip, newbie
>
> In the 2.5 release, we introduce new classes for Interactive Queries via KIP-535 (cf https://issues.apache.org/jira/browse/KAFKA-6144). The KIP did not specify the names for getter methods of `KeyQueryMetadata` explicitly and they were added in the PR as `getActiveHost()`, `getStandbyHosts()`, and `getPartition()`.
> However, in Kafka it is custom to not use the `get` prefix for getters and thus the methods should have been added as `activeHost()`, `standbyHosts()`, and `partition()`, respectively.
> We should consider renaming the methods accordingly, by deprecating the existing ones and adding the new ones in parallel.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)