You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jiabao-Sun (via GitHub)" <gi...@apache.org> on 2023/09/16 02:20:55 UTC

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23424: [FLINK-32445][runtime] Refactor BlobStoreService's closeAndCleanupAllData to cleanupAllData

Jiabao-Sun commented on code in PR #23424:
URL: https://github.com/apache/flink/pull/23424#discussion_r1327890114


##########
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheRetriesTest.java:
##########
@@ -148,7 +149,7 @@ void testBlobForJobFetchWithTooManyFailuresHa() throws IOException {
             testBlobFetchWithTooManyFailures(blobStoreService, new JobID(), PERMANENT_BLOB);
         } finally {
             if (blobStoreService != null) {
-                blobStoreService.closeAndCleanupAllData();
+                blobStoreService.cleanupAllData();

Review Comment:
   Thanks @gtk96 for catching this.
   Could you help review it again when you have time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org