You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/02/11 10:33:46 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5469: Memleak fixed with closing streams
tbw777 opened a new pull request, #5469:
URL: https://github.com/apache/netbeans/pull/5469
Some resources was in uncloused condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #5469: Streams from java.nio.file.Files have to be closed
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #5469:
URL: https://github.com/apache/netbeans/pull/5469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5469: Streams from java.nio.file.Files have to be closed
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #5469:
URL: https://github.com/apache/netbeans/pull/5469#discussion_r1103654371
##########
nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CheckEmbeddedBinaries.java:
##########
@@ -94,9 +97,11 @@ public void execute() throws BuildException {
throw new BuildException("Could not open " + manifest + ": " + x, x, getLocation());
}
- try {
- StringBuilder errorList = new StringBuilder();
- Files.list(dir.toPath())
+
+ StringBuilder errorList = new StringBuilder();
Review Comment:
The `errorList` can be moved back into the `try` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on a diff in pull request #5469: Streams from java.nio.file.Files have to be closed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5469:
URL: https://github.com/apache/netbeans/pull/5469#discussion_r1103682387
##########
nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CheckEmbeddedBinaries.java:
##########
@@ -94,9 +97,11 @@ public void execute() throws BuildException {
throw new BuildException("Could not open " + manifest + ": " + x, x, getLocation());
}
- try {
- StringBuilder errorList = new StringBuilder();
- Files.list(dir.toPath())
+
+ StringBuilder errorList = new StringBuilder();
Review Comment:
Fixed, ty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5469: Streams from java.nio.file.Files have to be closed
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5469:
URL: https://github.com/apache/netbeans/pull/5469#issuecomment-1426874430
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5469: Streams from java.nio.file.Files have to be closed
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #5469:
URL: https://github.com/apache/netbeans/pull/5469#issuecomment-1426848698
@tbw777 I would not say this is a good PR, but one which actually could be merged. It creates relative small noise only 6 files affected. Though only 2 of them are actually in the IDE. Even those two are on some auxiliary execution path, used once or twice during one IDE execution.
The most value of this PR is an educative one, which is summarized succinctly by the new title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5469: Streams from java.nio.file.Files have to be closed
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5469:
URL: https://github.com/apache/netbeans/pull/5469#issuecomment-1426856780
@lkishalmi
ty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists