You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/28 22:41:26 UTC
[GitHub] [helix] qqu0127 opened a new pull request, #2073: Fix race condition between instance drop and participant history update
qqu0127 opened a new pull request, #2073:
URL: https://github.com/apache/helix/pull/2073
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fix https://github.com/apache/helix/issues/1990
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
When an instance is dropped while its history is updated, it's possible the history path is recreated and instance appear in cluster again.
This PR address this issue by fixing the history update logic. On participant disconnect, we update the path if and only if the node path still exists (not always set). The creation logic stays the same, apparently we still want to have the history node.
### Tests
- [X] The following tests are written for this issue:
New test in TestParticipantManager
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on a diff in pull request #2073: Fix race condition between instance drop and participant history update
Posted by GitBox <gi...@apache.org>.
junkaixue commented on code in PR #2073:
URL: https://github.com/apache/helix/pull/2073#discussion_r861385353
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java:
##########
@@ -514,7 +515,7 @@ public void disconnect() {
try {
ParticipantHistory history = getHistory();
history.reportOffline();
- persistHistory(history);
+ persistHistory(history, true);
Review Comment:
Why this is true? If disconnect, we are giving up the node and if instance has been dropped between zk connection disconnect and this call, we will still create that.
It would be meaning less if there was a path does not exist and update this path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2073: Fix race condition between instance drop and participant history update
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2073:
URL: https://github.com/apache/helix/pull/2073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on pull request #2073: Fix race condition between instance drop and participant history update
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on PR #2073:
URL: https://github.com/apache/helix/pull/2073#issuecomment-1116427548
This PR is ready to merge, thanks @junkaixue for review and approval!
Commit message:
Fix race condition between instance drop and participant history update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2073: Fix race condition between instance drop and participant history update
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2073:
URL: https://github.com/apache/helix/pull/2073#discussion_r862125746
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java:
##########
@@ -514,7 +515,7 @@ public void disconnect() {
try {
ParticipantHistory history = getHistory();
history.reportOffline();
- persistHistory(history);
+ persistHistory(history, true);
Review Comment:
Chatted offline, here skipOnEmptyPath=true is the expected behavior.
Updated for BaseControllerDataProvider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org