You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/17 02:28:25 UTC
[GitHub] [ozone] kuenishi opened a new pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
kuenishi opened a new pull request #2540:
URL: https://github.com/apache/ozone/pull/2540
## What changes were proposed in this pull request?
The default value of `hadoop.http.idle_timeout.ms` seems to be inteneded as 10k in `HttpServer2.java`, but it is ignored and actually falls into 1000 defined in core-site.xml from hadoop-common implemented in HADOOP-15696 . I would also propose extending the default value to 60k, which is commonly used value among other Hadoop projects.
## What is the link to the Apache JIRA
HDDS-5620
## How was this patch tested?
- manual tests in laptop
- a unit test is added as `TestHttpServer2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#discussion_r690055327
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/HttpServer2.java
##########
@@ -49,6 +49,7 @@
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import com.google.common.annotations.VisibleForTesting;
Review comment:
nit:
the import should be in the below import block with other `com.google` import statement in alphabetical order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#issuecomment-901599949
Thanx @kuenishi for the contribution and @jojochuang for the review!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kuenishi commented on pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
kuenishi commented on pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#issuecomment-900961260
So at last I've got green at 4th trial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#issuecomment-900067438
> are we holding the commits until the jiras you mentioned get fixed?
That would help everyone feel the pain of these intermittent errors. ;) But I don't think we need to be so drastic. Just re-trigger the build with empty commit and hopefully eventually we can get a fully green run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kuenishi commented on pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
kuenishi commented on pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#issuecomment-899989865
The test failure in integration (filesystem-hdds) is something not related to this change. Is there any clue on it?
```
Error: Failures:
Error: TestPipelineClose.testPipelineCloseWithLogFailure:246
pipelineActionHandler.onMessage(
<Capturing argument>,
<any org.apache.hadoop.hdds.server.events.EventPublisher>
);
Wanted 1 time:
-> at org.apache.hadoop.hdds.scm.pipeline.PipelineActionHandler.onMessage(PipelineActionHandler.java:64)
But was 0 times.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#issuecomment-900050764
> ```
> Error: TestPipelineClose.testPipelineCloseWithLogFailure:246
> ```
HDDS-5604
> ```
> Error: TestSCMUpdateServiceGrpcServer.testClientUpdateWithDelayedRevoke:191 expected:<1> but was:<0>
> ```
HDDS-5319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai edited a comment on pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
adoroszlai edited a comment on pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#issuecomment-900067438
> are we holding the commits until the jiras you mentioned get fixed?
That would help everyone feel the pain of these intermittent errors. ;) But I don't think we need to be so drastic. Just re-trigger the build with empty commit, and hopefully eventually we can get a fully green run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn merged pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
ayushtkn merged pull request #2540:
URL: https://github.com/apache/ozone/pull/2540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kuenishi commented on a change in pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
kuenishi commented on a change in pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#discussion_r690063110
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/HttpServer2.java
##########
@@ -49,6 +49,7 @@
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import com.google.common.annotations.VisibleForTesting;
Review comment:
Thanks for the comment! Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kuenishi commented on pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
kuenishi commented on pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#issuecomment-900961260
So at last I've got green at 4th trial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kuenishi commented on pull request #2540: HDDS-5620. Fix and extend hadoop.http.idle_timeout.ms to 60k
Posted by GitBox <gi...@apache.org>.
kuenishi commented on pull request #2540:
URL: https://github.com/apache/ozone/pull/2540#issuecomment-900031570
Current test failure looks like also not related to this change, but it's not listed in HDDS-1127.
```
Error: Failures:
Error: TestSCMUpdateServiceGrpcServer.testClientUpdateWithDelayedRevoke:191 expected:<1> but was:<0>
[INFO]
Error: Tests run: 516, Failures: 1, Errors: 0, Skipped: 55
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org