[GitHub] [phoenix-connectors] ChinmaySKulkarni commented on a change in pull request #3: PHOENIX-5232: PhoenixDataWriter in Phoenix-Spark connector does not commit when mutation batch size is reached

[GitBox <gi...@apache.org>]

ChinmaySKulkarni commented on a change in pull request #3: PHOENIX-5232: PhoenixDataWriter in Phoenix-Spark connector does not commit when mutation batch size is reached
URL: https://github.com/apache/phoenix-connectors/pull/3#discussion_r274210330
 
 

 ##########
 File path: phoenix-spark/src/it/scala/org/apache/phoenix/spark/PhoenixSparkIT.scala
 ##########
 @@ -16,12 +16,17 @@ package org.apache.phoenix.spark
 import java.sql.DriverManager
 import java.util.Date
 
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil
 import org.apache.phoenix.schema.types.PVarchar
-import org.apache.phoenix.spark.datasource.v2.PhoenixDataSource
+import org.apache.phoenix.spark.datasource.v2.{PhoenixDataSource, PhoenixTestingDataSource}
+import org.apache.phoenix.spark.datasource.v2.reader.PhoenixTestingInputPartitionReader
+import org.apache.phoenix.spark.datasource.v2.writer.PhoenixTestingDataSourceWriter
 import org.apache.phoenix.util.{ColumnInfo, SchemaUtil}
+import org.apache.spark.SparkException
 import org.apache.spark.sql.types._
 
 Review comment:
   Yes it is a wildcard import. Might as well remove all such occurrences. Will remove them throughout.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services