You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Siqi Li (JIRA)" <ji...@apache.org> on 2015/02/02 19:13:35 UTC

[jira] [Commented] (YARN-3101) FairScheduler#fitInMaxShare was added to validate reservations but it does not consider it

    [ https://issues.apache.org/jira/browse/YARN-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301574#comment-14301574 ] 

Siqi Li commented on YARN-3101:
-------------------------------

The patch looks good to me

> FairScheduler#fitInMaxShare was added to validate reservations but it does not consider it 
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-3101
>                 URL: https://issues.apache.org/jira/browse/YARN-3101
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-3101-Siqi.v1.patch, YARN-3101-Siqi.v2.patch, YARN-3101.001.patch, YARN-3101.002.patch, YARN-3101.003.patch, YARN-3101.003.patch
>
>
> YARN-2811 added fitInMaxShare to validate reservations on a queue, but did not count it during its calculations. It also had the condition reversed so the test was still passing because both cancelled each other. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)