You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "stefanseifert (via GitHub)" <gi...@apache.org> on 2023/04/21 10:54:53 UTC

[GitHub] [sling-parent] stefanseifert commented on a diff in pull request #33: SLING-11841 Target Java 11 by default

stefanseifert commented on code in PR #33:
URL: https://github.com/apache/sling-parent/pull/33#discussion_r1173627956


##########
sling-parent/pom.xml:
##########
@@ -56,7 +56,7 @@
               - 9: Java 9
               - 10..19: Java 10-19
         -->
-        <sling.java.version>8</sling.java.version>
+        <sling.java.version>11</sling.java.version>

Review Comment:
   the comment above mentions java 8 as default
   
   there are two profiles in the prom "jdk8" and "jdk9-or-higher" which should be eliminated - but this is probably part of [SLING-11842](https://issues.apache.org/jira/browse/SLING-11842)?
   
   the enforcer execution `enforce-sling-java-version` should be updated to exclude java 8,9,10?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org