You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/26 16:02:41 UTC

[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #12116: [feat] New restful API task and task relation

github-code-scanning[bot] commented on code in PR #12116:
URL: https://github.com/apache/dolphinscheduler/pull/12116#discussion_r980238970


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessTaskRelationService.java:
##########
@@ -56,6 +70,28 @@
                                                   long processDefinitionCode,
                                                   long taskCode);
 
+    /**
+     * delete process task relation, will delete exists relation preTaskCode -> postTaskCode, throw error if not exists
+     *
+     * @param loginUser login user
+     * @param preTaskCode relation upstream code
+     * @param postTaskCode relation downstream code
+     */
+    void deleteTaskProcessRelationV2(User loginUser,

Review Comment:
   ## Useless parameter
   
   The parameter loginUser is unused.
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/1560)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org