You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/01/16 20:03:43 UTC
incubator-zeppelin git commit: Travis build fix
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master 282cf271a -> cbfd869c5
Travis build fix
### What is this PR for?
A lot of time travis fails with
Tests run: 11, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.77 sec <<< FAILURE! - in org.apache.zeppelin.notebook.NotebookTest
testSelectingReplImplementation(org.apache.zeppelin.notebook.NotebookTest) Time elapsed: 0.025 sec <<< ERROR!
org.apache.zeppelin.interpreter.InterpreterException: mock2 interpreter not found
at org.apache.zeppelin.notebook.NoteInterpreterLoader.get(NoteInterpreterLoader.java:148)
at org.apache.zeppelin.notebook.Note.run(Note.java:365)
at org.apache.zeppelin.notebook.NotebookTest.testSelectingReplImplementation(NotebookTest.java:119)
.
.
.
.
Tests in error:
NotebookTest.testSelectingReplImplementation:119 » Interpreter mock2 interpret...
This is fix for that error, this doesn't happens always. But here is a lot when this failed last time. https://s3.amazonaws.com/archive.travis-ci.org/jobs/102172625/log.txt
### What type of PR is it?
Improvement
### Todos
* [x] - Clear registered interpreters after a test case is executed.
### Is there a relevant Jira issue?
N/A
Author: Prabhjyot Singh <pr...@gmail.com>
Closes #642 from prabhjyotsingh/travisBuildFix and squashes the following commits:
ddda3c5 [Prabhjyot Singh] registeredInterpreters.clear() in tearDown
b07bca7 [Prabhjyot Singh] instead of 2 create 1 directory
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/cbfd869c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/cbfd869c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/cbfd869c
Branch: refs/heads/master
Commit: cbfd869c5f02660eeb4f0c40ddf67f27908deb7a
Parents: 282cf27
Author: Prabhjyot Singh <pr...@gmail.com>
Authored: Fri Jan 15 15:00:02 2016 +0530
Committer: Lee moon soo <mo...@apache.org>
Committed: Sat Jan 16 11:06:04 2016 -0800
----------------------------------------------------------------------
.../org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java | 1 +
.../src/test/java/org/apache/zeppelin/notebook/NotebookTest.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/cbfd869c/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java
index a0455eb..9496e4d 100644
--- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java
+++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteInterpreterLoaderTest.java
@@ -64,6 +64,7 @@ public class NoteInterpreterLoaderTest {
@After
public void tearDown() throws Exception {
delete(tmpDir);
+ Interpreter.registeredInterpreters.clear();
}
@Test
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/cbfd869c/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
index 34f7a1b..e98e680 100644
--- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
+++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
@@ -71,7 +71,7 @@ public class NotebookTest implements JobListenerFactory{
tmpDir = new File(System.getProperty("java.io.tmpdir")+"/ZeppelinLTest_"+System.currentTimeMillis());
tmpDir.mkdirs();
new File(tmpDir, "conf").mkdirs();
- notebookDir = new File(System.getProperty("java.io.tmpdir")+"/ZeppelinLTest_"+System.currentTimeMillis()+"/notebook");
+ notebookDir = new File(tmpDir + "/notebook");
notebookDir.mkdirs();
System.setProperty(ConfVars.ZEPPELIN_HOME.getVarName(), tmpDir.getAbsolutePath());