You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/24 01:19:12 UTC

[GitHub] [incubator-doris] xinyiZzz commented on pull request #9714: Fix lz4f optimization thread unsafe

xinyiZzz commented on PR #9714:
URL: https://github.com/apache/incubator-doris/pull/9714#issuecomment-1135296561

   > The thread_local approach is learned from #7911 by @xinyiZzz . It will be very appreciated if you have a look and check whether the usage of thread_local in this pr is right, @xinyiZzz .
   
   Sorry I just saw it, I see you have submitted a better solution to replace this pr.
   
   There is no problem with using thread_local, but I suggest adding thread local variables to the `ThreadContext` class. in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org