You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/01/14 07:07:49 UTC
[GitHub] [buildstream] abderrahim opened a new pull request #1562: use ruamel-yaml < 0.16
abderrahim opened a new pull request #1562:
URL: https://github.com/apache/buildstream/pull/1562
somewhere in the 0.16 series, ruamel.yaml broke round-tripping for the old API (See #1495)
This reverts 1c7a020 / [!1578](https://gitlab.com/BuildStream/buildstream/-/merge_requests/1578)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1562: use ruamel-yaml < 0.17
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1562:
URL: https://github.com/apache/buildstream/pull/1562#issuecomment-1043302474
@gtristan this should now be good to merge, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1562: use ruamel-yaml < 0.17
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1562:
URL: https://github.com/apache/buildstream/pull/1562#issuecomment-1042569133
Can we get a rebase of this ? The CI failure issue should be fixed by merging #1591.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on pull request #1562: use ruamel-yaml < 0.17
Posted by GitBox <gi...@apache.org>.
abderrahim commented on pull request #1562:
URL: https://github.com/apache/buildstream/pull/1562#issuecomment-1033482705
> This needs a rebase after applying #1564.
>
> In fact, I overlooked that #1564 was applied in error, that's my fault and probably needs to be fixed in some way.
>
> Updating the dependencies in this way leads to an inability to install on `ubuntu-18.04` and `centos-7.7.1908`.
Yeah, I noticed that. But I think it's better done in a different PR. So the problem is that those distros use EOL version of python (3.6), so if I update the requirements using a new version of python I end up with new versions of dependencies that don't support python 3.6.
I also noticed that in `requirements/cov-requirements.in`, there are different versions depending on python_version which means that `requirements/cov-requirements.txt` (which CI uses) will contain either depending on the version of python used to generate it.
I'm trying to regenerate requirements using python 3.6, let's see what it gives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1562: use ruamel-yaml < 0.17
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1562:
URL: https://github.com/apache/buildstream/pull/1562#issuecomment-1033396279
This needs a rebase after applying #1564.
In fact, I overlooked that #1564 was applied in error, that's my fault and probably needs to be fixed in some way.
Updating the dependencies in this way leads to an inability to install on `ubuntu-18.04` and `centos-7.7.1908`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on pull request #1562: use ruamel-yaml < 0.17
Posted by GitBox <gi...@apache.org>.
abderrahim commented on pull request #1562:
URL: https://github.com/apache/buildstream/pull/1562#issuecomment-1033500302
Let's see if #1586 fixes CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1562: use ruamel-yaml < 0.17
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1562:
URL: https://github.com/apache/buildstream/pull/1562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org