[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #133: feat: list files by git when possible

[GitBox <gi...@apache.org>]

kezhenxu94 commented on PR #133:
URL: https://github.com/apache/skywalking-eyes/pull/133#issuecomment-1236298610

   > Although we try to use ignore pattern present by a `.gitignore` file, it's possible that users have a global git ignore settings or manually ignore a file.
   > 
   > We can use git command to list files when runs under a git worksapce, 
   
   This is a good idea, but it looks like the implementation in this PR only lists files that have been committed into the codebase, however, in most cases, I'm using the tool in the following workflow:
   
   - In a git repo, checkout a new branch.
   - Do modifications, for example, `touch a-new-file.yaml`.
   - ... many other new files.
   - `license-eye h f` to fix all files that are missing license headers.
   - `git add . && git commit -m'...'`.
   
   In this PR, nothing will be fixed, even if I run `license-eye h f` after `git add .`.
   
   This also breaks users who used this tool as a git pre-commit hook.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org