You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/05/23 00:12:13 UTC

[GitHub] jerrypeng commented on a change in pull request #1833: adding worker to instance health check

jerrypeng commented on a change in pull request #1833: adding worker to instance health check
URL: https://github.com/apache/incubator-pulsar/pull/1833#discussion_r190091037
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/ThreadRuntime.java
 ##########
 @@ -114,6 +114,18 @@ public void stop() {
         return CompletableFuture.completedFuture(javaInstanceRunnable.getAndResetMetrics());
     }
 
+    @Override
 
 Review comment:
   can we do this for java first and add to python in subsequent PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services