[GitHub] [beam] johnjcasey commented on a diff in pull request #22105: More descriptive BT DEADLINE_EXCEEDED Error

[GitBox <gi...@apache.org>]

johnjcasey commented on code in PR #22105:
URL: https://github.com/apache/beam/pull/22105#discussion_r910369309


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1377,7 +1377,7 @@ static class BigtableWriteException extends IOException {
     public BigtableWriteException(KV<ByteString, Iterable<Mutation>> record, Throwable cause) {
       super(
           String.format(
-              "Error mutating row %s with mutations %s",
+              "Check BigTable cluster for resource usage and increase the number of nodes on the BigTable cluster if needed; error mutating row %s with mutations %s",

Review Comment:
   Also, this appears to handle all BT Write exceptions, so I don't think it makes sense to add this commentary unless it is a performance exception like DEADLINE_EXCEEDED



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1377,7 +1377,7 @@ static class BigtableWriteException extends IOException {
     public BigtableWriteException(KV<ByteString, Iterable<Mutation>> record, Throwable cause) {
       super(
           String.format(
-              "Error mutating row %s with mutations %s",
+              "Check BigTable cluster for resource usage and increase the number of nodes on the BigTable cluster if needed; error mutating row %s with mutations %s",

Review Comment:
   Nit: probably worth leading with the error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org