You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/14 14:00:08 UTC

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3021: Change List to SortedSet in RecoveryLogsIterator

dlmarion commented on code in PR #3021:
URL: https://github.com/apache/accumulo/pull/3021#discussion_r995794711


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/log/RecoveryLogsIterator.java:
##########
@@ -77,7 +79,7 @@ public RecoveryLogsIterator(ServerContext context, List<Path> recoveryLogDirs, L
 
     for (Path logDir : recoveryLogDirs) {
       LOG.debug("Opening recovery log dir {}", logDir.getName());
-      List<Path> logFiles = getFiles(vm, logDir);
+      SortedSet<Path> logFiles = getFiles(vm, logDir);

Review Comment:
   From what I can tell, the naming convention for the files is [here](https://github.com/apache/accumulo/blob/main/server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java#L253). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org