You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/04/10 11:26:18 UTC

Review Request 58294: RANGER-1505 - Remove KeyProtector code in KMS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58294/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1505
    https://issues.apache.org/jira/browse/RANGER-1505


Repository: ranger


Description
-------

The KMS service uses reflection to call on the com.sun.crypto.provider.KeyProtector class to encrypt/decrypt keys using a password. This causes problems with Java 9 and is generally unnecessary, as we can just use the normal Java API to do this.


Diffs
-----

  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java a001c08 


Diff: https://reviews.apache.org/r/58294/diff/1/


Testing
-------

Tested the Ranger KMS Service.


Thanks,

Colm O hEigeartaigh


Re: Review Request 58294: RANGER-1505 - Remove KeyProtector code in KMS

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58294/#review171528
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On April 10, 2017, 11:26 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58294/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 11:26 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1505
>     https://issues.apache.org/jira/browse/RANGER-1505
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The KMS service uses reflection to call on the com.sun.crypto.provider.KeyProtector class to encrypt/decrypt keys using a password. This causes problems with Java 9 and is generally unnecessary, as we can just use the normal Java API to do this.
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java a001c08 
> 
> 
> Diff: https://reviews.apache.org/r/58294/diff/1/
> 
> 
> Testing
> -------
> 
> Tested the Ranger KMS Service.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>