You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Joy Gao (JIRA)" <ji...@apache.org> on 2016/06/06 05:10:59 UTC

[jira] [Comment Edited] (AIRFLOW-184) Add clear/mark success to CLI

    [ https://issues.apache.org/jira/browse/AIRFLOW-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316177#comment-15316177 ] 

Joy Gao edited comment on AIRFLOW-184 at 6/6/16 5:10 AM:
---------------------------------------------------------

Just noticed that 'airflow backfill' and 'airflow run' both have a --mark_success flag which can be used to set Task Instances success just like the UI widget. 

The implementation for 'mark success' between CLI's backfill and UI are a bit different. In the UI, it directly reaches into db and change the state of the task instances as success, where as backfill's 'mark success' will re-schedule the job to job queue (and when job.run() is executed async, it bypasses the actual work and mark the job as success). Would it make more sense to decouple 'mark success' as a top-level cli command? 

Also, there's a small corner case in backfill's mark_success: for any TIs that had state 'skipped', it does not get marked as 'success' (where as in the UI we can mark skipped to success).


was (Author: joyg):
Just noticed that 'airflow backfill' and 'airflow run' both have a --mark_success flag which can be used to set Task Instances success just like the UI widget. 

> Add clear/mark success to CLI
> -----------------------------
>
>                 Key: AIRFLOW-184
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-184
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: cli
>            Reporter: Chris Riccomini
>            Assignee: Joy Gao
>
> AIRFLOW-177 pointed out that the current CLI does not allow us to clear or mark success a task (including upstream, downstream, past, future, and recursive) the way that the UI widget does. Given a goal of keeping parity between the UI and CLI, it seems like we should support this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)